Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update interface to use PactV3 #66

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tomerslice
Copy link

@tomerslice tomerslice commented Dec 31, 2023

Added PactV3 and testing agains nestjs-10 and pact-12

Description

Updated interface and dependencies.

Motivation and Context

I want to use new API so I need this update.

The original issue was closed, but I hope that this PR will be merged:
#31

How Has This Been Tested?

Using the old tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@YOU54F
Copy link
Member

YOU54F commented Apr 3, 2024

thanks for the contrib. this is a breaking change for users and isn't transparent as you are renaming a new import under the same export.

it would need to be documented, or catered to support the v2 and v3 interfaces.

there is a choice if supporting both interfaces, how is it presented to the user. eg is it abstracted away?

please note the v4 pact js interface is now exposed and it supports async/sync messages and plugins, so this may impact any design decisions

@YOU54F
Copy link
Member

YOU54F commented Apr 3, 2024

sorry for delay in getting a response over to you! if you or others do want to push this forward, we can support you. we tend to be more active over via slack.pact.io if we miss you in gh

@tomerslice
Copy link
Author

I read the docs here:
Migration from pact v2 to v3 in js
From my understanding, there are no breaking changes in the Provider api, which nestjs-pact uses.

@YOU54F
Copy link
Member

YOU54F commented Apr 21, 2024

it uses both the consumer and provider api. you've updated the consumer in this pr as well as the provider

@tomerslice
Copy link
Author

I will update the PR to support the consumer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants