Fix/issue 1133 remove AnyTemplate
#1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mefellows
changed the title
AnyTemplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the remaining
AnyTemplatereferences from previous parts of the code base, excluding the original HTTP DSL (as this is old and stable, and most users would be usingPactV3or greater).It is a widening of the types, so is technically backwards compatible on method inputs, however some exported types may be used outside of Pact and the widening from
AnyTemplatetounknownmight require type casting (asunknownis not iterable, for instance). This is preferable to the current situation however, which is breaking the message pact interface (#1133) and also - as described in #1061 - misleading.