Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protoc 3.19.1 (default) doesn't support ARM for MacOS #33

Closed
stan-is-hate opened this issue Oct 17, 2023 · 1 comment
Closed

Protoc 3.19.1 (default) doesn't support ARM for MacOS #33

stan-is-hate opened this issue Oct 17, 2023 · 1 comment

Comments

@stan-is-hate
Copy link
Contributor

I mean it's easy to change which protoc my plugin uses on my machine, but would it make sense to update the default version of the protoc to something newer?
I can send a PR updating that single line in the json file, but not sure what's the right process for testing it is, and don't have access to enough OSs or hardware to verify it all works across the board
@YOU54F YOU54F mentioned this issue May 14, 2024
Closed
YOU54F added a commit that referenced this issue Jul 23, 2024
@YOU54F
fix: update protobuf version to 25.2
c40fc59 
fixes #63 / #33 

works OOB with MacOS aarch64. 

26.x/27.x fail on MacOS aarch64 for integrations with via pact_ffi for

- php
- swift
- dotnet
- lua
@YOU54F YOU54F mentioned this issue Jul 23, 2024
Closed
@YOU54F
Copy link
Member

YOU54F commented Jul 23, 2024

0.4.0 of the pact-protobuf-plugin now uses 21.12 which supports macos-aarch64

change introduced in a1fad28

Thanks Stan

@YOU54F YOU54F closed this as completed Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@YOU54F @stan-is-hate