fix: respect package namespaces when resolving message descriptors #60
+146
−95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks @ermul Can you rebase against |
|
Also thank you for the fix and @stan-is-hate for the investigation 🙌🏾 |
ermul
force-pushed
the
package-namespace-fixes
branch
from
2740f50 to
0f47677
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change fixes a couple of bugs exposed by @stan-is-hate in #59 where package namespaces are not taken into account when looking up protobuf messages.
Testing
Ran
integrated_tests/imported_messagein a loop ~20 times without a failure locally.