all tests pass again

paddymul · Nov 23, 2023 · cb954ae · cb954ae
1 parent 08a6a06
commit cb954ae
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 2 deletions.
diff --git a/buckaroo/customizations/histogram.py b/buckaroo/customizations/histogram.py
@@ -94,8 +94,10 @@ def series_summary(sampled_ser, ser):
         if pd.api.types.is_bool_dtype(ser):
             return dict(histogram_args={})
         vals = ser.dropna()
-        low_tail = np.quantile(ser, 0.01)
-        high_tail =  np.quantile(ser, 0.99)
+        if len(vals) == 0:
+            return dict(histogram_args={})
+        low_tail = np.quantile(vals, 0.01)
+        high_tail =  np.quantile(vals, 0.99)
         low_pass  = ser > low_tail 
         high_pass = ser < high_tail
         meat = vals[low_pass & high_pass]

diff --git a/tests/unit/analysis_test.py b/tests/unit/analysis_test.py
@@ -127,6 +127,23 @@ def test_perverse_on_histogram():
              nan_per=0
              ))
 
+def test_perverse_on_histogram2():
+
+    series_result = Histogram.series_summary(
+        PERVERSE_DF['UInt8None'], PERVERSE_DF['UInt8None'])
+    assert series_result == {'histogram_args':{}}
+    summary_result = Histogram.computed_summary(
+        dict(histogram_args={},
+             length=10, 
+             value_counts=pd.Series(
+                 [10],
+                 index=[False]),
+             min=False,
+             max=False,
+             is_numeric=True,
+             nan_per=0
+             ))
+