Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Sinistea and Poltchageist line alt forms now available #4989

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

Madmadness65
Copy link
Collaborator

What are the changes the user will see?

Antique form Sinistea & Polteageist, Artisan form Poltchageist, and Masterpiece form Sinistcha can now be encountered in the wild. As their form differences are only visual (and a small difference at best), there isn't a way to tell until you catch one.

Why am I making these changes?

It is a forgotten form difference Pokémon and it makes them available in this manner. You could already get the alternate forms via evolution item, however.

What are the changes from a developer perspective?

Entries added for the Sinistea and Poltchageist evolution families in the getSpeciesFormIndex.

Screenshots/Videos

image

How to test the changes?

Encounter any of the Sinistea or Poltchageist lines, either naturally or via species override. The alternate forms will have a chance to appear.

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • [N/A] Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • [N/A] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • [N/A] Has a locales PR been created on the locales repo?
    • [N/A] If so, please leave a link to it here:
  • [N/A] Has the translation team been contacted for proofreading/translation?

@Madmadness65 Madmadness65 added the Miscellaneous Changes that don't fit under any other label label Dec 14, 2024
@Madmadness65 Madmadness65 requested a review from a team as a code owner December 14, 2024 00:43
@DayKev
Copy link
Collaborator

DayKev commented Dec 14, 2024

There's zero difference in Pokerogue with those forms though, not even a minor visual difference because we don't use 3D models and the difference is on the underside. They might as well not even be in the game.

@Snailman11
Copy link
Collaborator

Have you checked the spawning for Poltchageist and Sinistcha?

@Fontbane
Copy link
Contributor

Shouldn't they be 1 in 100 rather than 1 in 2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Miscellaneous Changes that don't fit under any other label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants