Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Move] Implement Quash #5049

Open
wants to merge 19 commits into
base: beta
Choose a base branch
from
Open

[Move] Implement Quash #5049

wants to merge 19 commits into from

Conversation

emdeann
Copy link

@emdeann emdeann commented Dec 27, 2024

What are the changes the user will see?

Quash is now usable in battle.

Why am I making these changes?

For the massive amount of usage this move will surely get

What are the changes from a developer perspective?

  • Adds ForceLastAttr (extends MoveEffectAttr), which pushes the MovePhase of the target pokemon to the end of the turn
  • If multiple pokemon are quashed in the same turn, they move in speed order
    • ForceLastAttr is aware of whether other moves are quashed thru new forcedLast field in MovePhase

Screenshots/Videos

2024-12-27.15-43-47.mp4

How to test the changes?

Added automated tests.
Basic playtesting can be done with just:

const overrides = {
  MOVESET_OVERRIDE: [Moves.QUASH],
  BATTLE_TYPE_OVERRIDE: "double"
} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

but manual testing multiple quashes in a turn, etc is a bit more involved

Checklist

  • I'm using beta as my base branch
  • There is no overlap with another PR?
  • The PR is self-contained and cannot be split into smaller PRs?
  • Have I provided a clear explanation of the changes?
  • Have I tested the changes manually?
  • Are all unit tests still passing? (npm run test)
    • Have I created new automated tests (npm run create-test) or updated existing tests related to the PR's changes?
  • Have I provided screenshots/videos of the changes (if applicable)?
    • [ ] Have I made sure that any UI change works for both UI themes (default and legacy)?

Are there any localization additions or changes? If so:

  • Has a locales PR been created on the locales repo?
  • Has the translation team been contacted for proofreading/translation? (locales pr is merged)

@emdeann emdeann requested a review from a team as a code owner December 27, 2024 23:59
@Tempo-anon Tempo-anon added the Move Affects a move label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Move Affects a move
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants