Support static linking #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update CMakeLists.txt
alexkutsan
force-pushed
the
feat/support_static_linking
branch
from
a1e9997 to
4192f70
Compare
pageldev
added a commit
that referenced
this pull request
Nov 25, 2023
…dling #86 * remove explicit static library target, build static library by default, use '-DBUILD_SHARED_LIBS=On' to get shared libs * set compiler flags for MSVC correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping library shared only makes it impossible to install in a system wrapped in pybind11 pythons module.
Details : pybind/cmake_example#11
So, added additional target for static linking