-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CES-456] Definition of a module that create a base environment for development #163
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 578f8aa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tags = var.tags | ||
} | ||
|
||
resource "azurerm_resource_group" "test" { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this rg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is a test resource group, if you create a test environment you can do what you want with this rg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall who is going to do tests use this module or any one they like? What if multiple people are doing tests simultaneously?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module creates the basic infrastructure, and this resource group is not structurally significant—it’s just a “suggestion”: similar to the common resource group for shared resources, the test one is provided for placing test resources, whether created through the portal or code.
It can be useful for those conducting tests without needing to create a dedicated resource group or for cleaning up old test resources in one go. However, since it’s just a logical grouping, we can remove it if it causes more confusion than value. The main risk is that without it, users testing resources might create them in the “common” or “network” resource groups for convenience.
List of changes
The module, named
azure_core_infra
, includes the following:Motivation and context
The purpose of this pull request is to introduce a module that provisions all the resources required for the initial configuration of a subscription, which can be utilized for testing or other purposes.
Type of changes
Does this introduce a change to production resources with possible user impact?
Other information