Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CES-456] Definition of a module that create a base environment for development #163

Open
wants to merge 19 commits into
base: main
Choose a base branch
from

Conversation

mamu0
Copy link
Contributor

@mamu0 mamu0 commented Nov 19, 2024

List of changes

The module, named azure_core_infra, includes the following:

  • A virtual network (VNet) with subnets for private endpoints.
  • A VPN, if specified.
  • Resource groups for the VNet, common resources, and testing.
  • A common Key Vault with a private endpoint.
  • Private DNS zones for all resource types.

Motivation and context

The purpose of this pull request is to introduce a module that provisions all the resources required for the initial configuration of a subscription, which can be utilized for testing or other purposes.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Other information

@mamu0 mamu0 requested a review from a team as a code owner November 19, 2024 10:34
Copy link

changeset-bot bot commented Nov 19, 2024

🦋 Changeset detected

Latest commit: 578f8aa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
azure_core_infra Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mamu0 mamu0 requested a review from a team as a code owner November 19, 2024 11:27
tags = var.tags
}

resource "azurerm_resource_group" "test" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the purpose of this rg?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a test resource group, if you create a test environment you can do what you want with this rg

Copy link
Contributor

@Krusty93 Krusty93 Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall who is going to do tests use this module or any one they like? What if multiple people are doing tests simultaneously?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module creates the basic infrastructure, and this resource group is not structurally significant—it’s just a “suggestion”: similar to the common resource group for shared resources, the test one is provided for placing test resources, whether created through the portal or code.

It can be useful for those conducting tests without needing to create a dedicated resource group or for cleaning up old test resources in one go. However, since it’s just a logical grouping, we can remove it if it causes more confusion than value. The main risk is that without it, users testing resources might create them in the “common” or “network” resource groups for convenience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants