-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IMN 538 - Fix user info fetch during contract creation #543
IMN 538 - Fix user info fetch during contract creation #543
Conversation
de4d157
to
8335b96
Compare
8e8c4fc
to
f56f444
Compare
f56f444
to
316c53f
Compare
@@ -127,16 +129,29 @@ const getAttributeInvolved = async ( | |||
}; | |||
|
|||
const getSubmissionInfo = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MalpenZibo Does this apply only to this getSubmissionInfo
case or also to the getActivationInfo
below?
If it applies also to that case, maybe you could move this logic from here into the retrieveUser
, which is called by both functions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be applied just to submission info.
The submission can be performed only by the consumer, and we can safely take the details from it.
The activation can be done both by consumer and by producer, but in both cases the getActivationInfo
is called by the user who also activated the agreement. This is why we can take the info starting from the context (of the jwt)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment (the same question applies to the solution being applied to Scala, so maybe it needs also to be clarified on that side)
I double checked, the same question I left here applies to the fix on the Scala code cc @nttdata-rtorsoli & @galales / @beetlecrunch |
@@ -127,16 +129,29 @@ const getAttributeInvolved = async ( | |||
}; | |||
|
|||
const getSubmissionInfo = async ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be applied just to submission info.
The submission can be performed only by the consumer, and we can safely take the details from it.
The activation can be done both by consumer and by producer, but in both cases the getActivationInfo
is called by the user who also activated the agreement. This is why we can take the info starting from the context (of the jwt)
Closes IMN-538
From scala counterpart pagopa/interop-be-agreement-process#263