-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1830] Wallet errors refactor #6455
Open
gispada
wants to merge
24
commits into
master
Choose a base branch
from
SIW-1830-wallet-errors-refactor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+639
−415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gispada
requested review from
ChrisMattew,
freddi301 and
a team
as code owners
November 25, 2024 15:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR refactors how errors are handled in ITW flows following the refactor in
io-react-native-wallet
. Now it's possible to differentiate between issuer and wallet provider errors.List of changes proposed in this pull request
io-react-native-wallet
to0.25.0
(as a side-effect of this update, the integrity key tag is now needed to revoke the wallet instance)io-react-native-wallet
reason
property in ITW failure screens. Known reason types must be declared, in order to avoid unkown reasons as much as possible.WALLET_PROVIDER_GENERIC
andUNEXPECTED
failuresMixpanel
ITW_ADD_CREDENTIAL_UNEXPECTED_FAILURE
Mixpanel event to track unexpected errors that occur during credential issuance, to be consistent withITW_ID_REQUEST_UNEXPECTED_FAILURE
caused_by
property toITW_ADD_CREDENTIAL_FAILURE
andITW_ID_REQUEST_FAILURE
How to test
/status
endpoint