-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(IT Wallet): [SIW-1795] Problem with SPID Login Using Custom Tab #6409
Draft
RiccardoMolinari95
wants to merge
33
commits into
master
Choose a base branch
from
SIW-1795-login-webview-instead-custom-tab
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix(IT Wallet): [SIW-1795] Problem with SPID Login Using Custom Tab #6409
RiccardoMolinari95
wants to merge
33
commits into
master
from
SIW-1795-login-webview-instead-custom-tab
+1,340
−736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a custom tab, unified the flow for spid, cieId and cieL3
RiccardoMolinari95
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
November 15, 2024 15:13
…-login-webview-instead-custom-tab
RiccardoMolinari95
changed the base branch from
master
to
SIW-1830-wallet-errors-refactor
November 26, 2024 10:20
…-login-webview-instead-custom-tab
…-login-webview-instead-custom-tab
RiccardoMolinari95
temporarily deployed
to
dev
November 26, 2024 10:55
— with
GitHub Actions
Inactive
RiccardoMolinari95
had a problem deploying
to
dev
November 26, 2024 10:55
— with
GitHub Actions
Failure
pagopa-github-bot
changed the title
[SIW-1795] Problem with SPID Login Using Custom Tab
fix(IT Wallet): [SIW-1795] Problem with SPID Login Using Custom Tab
Nov 26, 2024
RiccardoMolinari95
had a problem deploying
to
dev
November 26, 2024 11:17
— with
GitHub Actions
Failure
RiccardoMolinari95
temporarily deployed
to
dev
November 26, 2024 11:17
— with
GitHub Actions
Inactive
RiccardoMolinari95
changed the base branch from
SIW-1830-wallet-errors-refactor
to
master
November 26, 2024 11:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
Depends on #6455
Short description
This PR addresses the issue encountered by some users when logging in via SPID for PID issuance on ITWallet, specifically related to the opening of the
CustomTab
.Unified the authorization flows for SPID, Cie + PIN, and CieID. Previously, SPID and CieID had a unique flow, while Cie + PIN followed two separate flows (
startAuthFlow
andcompleteAuthFlow
). Replaced the opening of aCustomTab
with aWebView
for SPID authentication.List of changes proposed in this pull request
ItwSpidIdpLoginScreen
to handle the SPID authentication process within aWebView
. This screen loads theauthUrl
generated bystartAuthFlow
and sends theauthRedirectURL
back to the state machine when it containsitWalletIssuanceRedirectUri
openUrlAndListenForAuthRedirect
, which opens theauthUrl
in the browser for CieID and provides theauthRedirectURL
getAuthRedirectUrl
used in theCieIDBuildAuthRedirectUrl
state of CieID, which utilizesopenUrlAndListenForAuthRedirect
to complete the authenticationHow to test
To test the changes, try obtaining the eID using all three authentication methods (SPID, Cie + PIN, and CieID) and ensure that the eID is successfully obtained in each case. After successfully obtaining the eID, proceed to obtain a credential and ensure that the process completes without issues.
Screen.Recording.2024-11-15.at.11.06.42.mov