chore(IT Wallet): [SIW-1665] Hide eID card in wallet #6214

gispada · 2024-09-26T08:21:44Z

Warning

Depends on pagopa/io-react-native-wallet#145

Short description

This PR hides the eID card in the wallet screen. It also adds a bottom sheet to display information on the digital identity.

List of changes proposed in this pull request

Removed the eID card from the wallet screen
Added a banner to inform the user the wallet is active
Added a bottom sheet component to display the eID claims and the issuance date
Added expiration and issuedAt properties to StoredCredential type, with Redux Persist migration

How to test

If you have an existing wallet, check the following:

The migration worked, and every credential in the Redux Store now has issuedAt and expiration
The eID card is not visible in the wallet screen, only other credentials
The bottom sheet that appears pressing on "Cos'è?" properly displays the issuance date

Reset the wallet and get all credentials, then check the same points as above.

pagopa-github-bot · 2024-09-26T08:23:14Z

Affected stories

⚙️ SIW-1665: [io-app] Sostituzione card eID con badge e bottom sheet nella sezione portafoglio

Generated by 🚫 dangerJS against ece3903

ts/features/newWallet/components/WalletCardsContainer.tsx

codecov · 2024-09-26T10:22:45Z

Codecov Report

Attention: Patch coverage is 54.54545% with 30 lines in your changes missing coverage. Please review.

Project coverage is 47.15%. Comparing base (4f204b4) to head (ece3903).
Report is 533 commits behind head on master.

Files with missing lines	Patch %	Lines
...tures/itwallet/common/store/reducers/migrations.ts	12.00%	22 Missing ⚠️
...common/components/ItwEidInfoBottomSheetContent.tsx	69.23%	4 Missing ⚠️
.../credentials/saga/handleItwCredentialsStoreSaga.ts	0.00%	3 Missing ⚠️
...twallet/common/components/ItwWalletReadyBanner.tsx	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6214      +/-   ##
==========================================
- Coverage   48.42%   47.15%   -1.27%     
==========================================
  Files        1488     1781     +293     
  Lines       31617    35933    +4316     
  Branches     7669     8501     +832     
==========================================
+ Hits        15311    16945    +1634     
- Misses      16238    18930    +2692     
+ Partials       68       58      -10

Files with missing lines	Coverage Δ
ts/features/design-system/core/DSWallet.tsx	`12.50% <ø> (-4.17%)`	⬇️
.../itwallet/common/components/ItwDiscoveryBanner.tsx	`84.61% <100.00%> (ø)`
...s/features/itwallet/common/store/reducers/index.ts	`100.00% <ø> (ø)`
...twallet/common/utils/itwCredentialIssuanceUtils.ts	`10.71% <ø> (ø)`
...features/itwallet/common/utils/itwIssuanceUtils.ts	`21.31% <ø> (ø)`
...entials/saga/handleWalletCredentialsRehydration.ts	`100.00% <100.00%> (ø)`
...ures/itwallet/credentials/store/selectors/index.ts	`60.00% <100.00%> (ø)`
...Wallet/components/WalletCardsCategoryContainer.tsx	`100.00% <100.00%> (ø)`
...ures/newWallet/components/WalletCardsContainer.tsx	`97.36% <100.00%> (+8.47%)`	⬆️
...twallet/common/components/ItwWalletReadyBanner.tsx	`88.88% <88.88%> (ø)`
... and 3 more

... and 1347 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6010dea...ece3903. Read the comment docs.

dpulls · 2024-09-27T13:07:59Z

⚠️ Dpulls not installed on repository pagopa/io-react-native-wallet. Checkout our quickstart for how to install.

LazyAfternoons

If we are not sure wether or not the SD-JWT includes the required fields, why don't we make them nullable and show a placeholder label which says that something went wrong?
I think that using the current date might be misleading and potentially it could shadow an error, even if that's a very remote possibility.

gispada · 2024-10-02T10:37:28Z

If we are not sure wether or not the SD-JWT includes the required fields, why don't we make them nullable and show a placeholder label which says that something went wrong? I think that using the current date might be misleading and potentially it could shadow an error, even if that's a very remote possibility.

I wanted to avoid handling null values that are very unlikely, because both exp and iat should be included in SD-JWTs, as per specification. What about using the Unix epoch time as default instead of the current time?

LazyAfternoons · 2024-10-02T12:14:45Z

If we are not sure wether or not the SD-JWT includes the required fields, why don't we make them nullable and show a placeholder label which says that something went wrong? I think that using the current date might be misleading and potentially it could shadow an error, even if that's a very remote possibility.

I wanted to avoid handling null values that are very unlikely, because both exp and iat should be included in SD-JWTs, as per specification. What about using the Unix epoch time as default instead of the current time?

I agree that they must be part of the SD-JWT. Maybe we can make the verifyAndParseCredential implementation thrown if they are not found during that step. I think we can fix this up later so they app doesn't have to handle null values or use defaults which might potentially shadow an issue.

dpulls · 2024-10-02T13:19:53Z

⚠️ Dpulls not installed on repository pagopa/io-react-native-wallet. Checkout our quickstart for how to install.

gispada · 2024-10-02T13:20:34Z

I modified the way issuedAt is handled in d5223e9. There is a dependency on pagopa/io-react-native-wallet#145.

dpulls · 2024-10-02T13:24:31Z

⚠️ Dpulls not installed on repository pagopa/io-react-native-wallet. Checkout our quickstart for how to install.

LazyAfternoons

There's an issue with the banner text:

gispada · 2024-10-02T15:40:28Z

There's an issue with the banner text:

Unfortunately that is an issue with the Alert component from the design system. It is not perfectly centered with just one line.

LazyAfternoons

LGTM, let's wait for @mastro993 approve as well. Thanks.

ts/features/itwallet/common/components/ItwEidInfoBottomSheetContent.tsx

mastro993

LGTM!

…creen (#6221) > [!WARNING] > Depends on #6214 ## Short description This PR adds filters in the wallet screen. They are only visible when the wallet contains at least one credential (not considering the eID). ## List of changes proposed in this pull request - Filter tabs in the wallet screen with tests - Reducer logic ## How to test 1. Disable the wallet instance: filters should not be visibile 2. Get the eID: filters should not be visible 3. Get another credential: filters should be visible <img src="https://github.com/user-attachments/assets/b0f2697e-6bf8-4819-b47b-f1d1fd9e6328" width="400" /> --------- Co-authored-by: Federico Mastrini <[email protected]>

gispada added 5 commits September 24, 2024 16:35

refactor: change wallet components to conform to the new design

f7b1847

feat: add bottom sheet for eID information

42f20e5

chore: remove Alert

a848270

refactor: improve code readability

e6b8ecd

Merge branch 'master' into SIW-1665-eid-card-removal

e115a93

gispada temporarily deployed to dev September 26, 2024 08:21 — with GitHub Actions Inactive

gispada had a problem deploying to dev September 26, 2024 08:21 — with GitHub Actions Failure

pagopa-github-bot added the IT Wallet label Sep 26, 2024

mastro993 reviewed Sep 26, 2024

View reviewed changes

ts/features/newWallet/components/WalletCardsContainer.tsx Outdated Show resolved Hide resolved

gispada added 3 commits September 26, 2024 11:18

refactor: footer in WalletCardsCategoryContainer

c480b3f

chore: fix ITW tests

8707061

chore: add more tests

0259b66

gispada temporarily deployed to dev September 26, 2024 09:58 — with GitHub Actions Inactive

gispada had a problem deploying to dev September 26, 2024 09:58 — with GitHub Actions Failure

chore: fix type error

d23f9e7

gispada temporarily deployed to dev September 26, 2024 10:06 — with GitHub Actions Inactive

Merge branch 'master' into SIW-1665-eid-card-removal

ceed91c

gispada temporarily deployed to dev September 27, 2024 09:06 — with GitHub Actions Inactive

chore: add comments

6c54084

gispada temporarily deployed to dev September 27, 2024 10:42 — with GitHub Actions Inactive

chore: simplify test cases

573b178

gispada temporarily deployed to dev September 27, 2024 13:02 — with GitHub Actions Inactive

gispada mentioned this pull request Sep 27, 2024

chore(IT Wallet): [SIW-1666] Add category filter tabs to the wallet screen #6221

Merged

gispada temporarily deployed to dev October 2, 2024 06:13 — with GitHub Actions Inactive

LazyAfternoons reviewed Oct 2, 2024

View reviewed changes

chore: handle undefined issuedAt

d5223e9

gispada had a problem deploying to dev October 2, 2024 13:16 — with GitHub Actions Error

Merge branch 'master' into SIW-1665-eid-card-removal

c9d86dc

gispada temporarily deployed to dev October 2, 2024 13:17 — with GitHub Actions Inactive

gispada had a problem deploying to dev October 2, 2024 13:17 — with GitHub Actions Error

gispada added 2 commits October 2, 2024 15:28

Merge branch 'master' into SIW-1665-eid-card-removal

27702fd

chore: update io-react-native-wallet

ba8d1c2

gispada temporarily deployed to dev October 2, 2024 13:29 — with GitHub Actions Inactive

LazyAfternoons self-requested a review October 2, 2024 14:59

LazyAfternoons requested changes Oct 2, 2024

View reviewed changes

LazyAfternoons self-requested a review October 2, 2024 16:33

LazyAfternoons approved these changes Oct 2, 2024

View reviewed changes

mastro993 requested changes Oct 3, 2024

View reviewed changes

ts/features/itwallet/common/components/ItwEidInfoBottomSheetContent.tsx Show resolved Hide resolved

mastro993 approved these changes Oct 3, 2024

View reviewed changes

Merge branch 'master' into SIW-1665-eid-card-removal

ece3903

mastro993 temporarily deployed to dev October 3, 2024 10:43 — with GitHub Actions Inactive

mastro993 merged commit f9a8b44 into master Oct 3, 2024
13 checks passed

mastro993 deleted the SIW-1665-eid-card-removal branch October 3, 2024 10:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(IT Wallet): [SIW-1665] Hide eID card in wallet #6214

chore(IT Wallet): [SIW-1665] Hide eID card in wallet #6214

gispada commented Sep 26, 2024 •

edited

Loading

pagopa-github-bot commented Sep 26, 2024 •

edited by jira bot

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading

dpulls bot commented Sep 27, 2024

LazyAfternoons left a comment •

edited

Loading

gispada commented Oct 2, 2024

LazyAfternoons commented Oct 2, 2024 •

edited

Loading

dpulls bot commented Oct 2, 2024

gispada commented Oct 2, 2024

dpulls bot commented Oct 2, 2024

LazyAfternoons left a comment •

edited

Loading

gispada commented Oct 2, 2024

LazyAfternoons left a comment

mastro993 left a comment

chore(IT Wallet): [SIW-1665] Hide eID card in wallet #6214

chore(IT Wallet): [SIW-1665] Hide eID card in wallet #6214

Conversation

gispada commented Sep 26, 2024 • edited Loading

Short description

List of changes proposed in this pull request

How to test

pagopa-github-bot commented Sep 26, 2024 • edited by jira bot Loading

Affected stories

codecov bot commented Sep 26, 2024 • edited Loading

Codecov Report

dpulls bot commented Sep 27, 2024

LazyAfternoons left a comment • edited Loading

Choose a reason for hiding this comment

gispada commented Oct 2, 2024

LazyAfternoons commented Oct 2, 2024 • edited Loading

dpulls bot commented Oct 2, 2024

gispada commented Oct 2, 2024

dpulls bot commented Oct 2, 2024

LazyAfternoons left a comment • edited Loading

Choose a reason for hiding this comment

gispada commented Oct 2, 2024

LazyAfternoons left a comment

Choose a reason for hiding this comment

mastro993 left a comment

Choose a reason for hiding this comment

gispada commented Sep 26, 2024 •

edited

Loading

pagopa-github-bot commented Sep 26, 2024 •

edited by jira bot

Loading

codecov bot commented Sep 26, 2024 •

edited

Loading

LazyAfternoons left a comment •

edited

Loading

LazyAfternoons commented Oct 2, 2024 •

edited

Loading

LazyAfternoons left a comment •

edited

Loading