Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-399] Extend dark mode to other parts of the app #6285

Merged
merged 47 commits into from
Nov 22, 2024

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 15, 2024

Important

This PR is not directly dependent on the following PR. However, it needs the new IOText to avoid unnecessary extra work:

Short description

This PR extends dark mode support to some parts of the app

List of changes proposed in this pull request

  • General
    • Adapt LoadingSpinnerOverlay
  • Payments
    • Adapt the payment biz event detail
    • Fix ListItemTransaction partial dark mode support
  • Settings
    • Adapt the fiscal code screen
    • Remove unnecessary ContentWrapper (by adding a new prop to IOScrollViewWithLargeHeader)
  • Services
    • Adapt the detail screens (footer actions not included because they need a general refactor)
  • Messages
    • Adapt MessageDetailsFooter

How to test

Run the app in the local environment, enable Dark mode and navigate through the entire app, in particular the screens mentioned above

@dmnplb dmnplb added Design System New visual language and reduction of previous UI clutter Dark mode 🌝 labels Oct 15, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-399] Extend dark mode to other parts of the app chore(Cross): [IOAPPX-399] Extend dark mode to other parts of the app Oct 15, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 15, 2024

Affected stories

  • ⚙️ IOAPPX-399: Estensione del supporto alla modalità scura ad altre sezioni/schermate
    subtask of

Generated by 🚫 dangerJS against 56b9d6c

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 43.54839% with 35 lines in your changes missing coverage. Please review.

Project coverage is 47.86%. Comparing base (4f204b4) to head (56b9d6c).
Report is 760 commits behind head on master.

Files with missing lines Patch % Lines
...onents/PaymentsBizEventsTransactionTotalAmount.tsx 0.00% 6 Missing ⚠️
ts/components/CalendarsListContainer.tsx 0.00% 4 Missing ⚠️
...ces/details/components/CardWithMarkdownContent.tsx 20.00% 4 Missing ⚠️
...nts/PaymentsBizEventsTransactionHeadingSection.tsx 0.00% 3 Missing ⚠️
...onents/PaymentsBizEventsTransactionInfoSection.tsx 0.00% 2 Missing ⚠️
...eens/PaymentsTransactionBizEventsDetailsScreen.tsx 0.00% 2 Missing ⚠️
...nents/PaymentsMethodDetailsBaseScreenComponent.tsx 0.00% 2 Missing ⚠️
...ion/components/WalletTransactionHeadingSection.tsx 0.00% 2 Missing ⚠️
...action/components/WalletTransactionInfoSection.tsx 0.00% 2 Missing ⚠️
...ion/components/WalletTransactionReceiptDivider.tsx 33.33% 2 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6285      +/-   ##
==========================================
- Coverage   48.42%   47.86%   -0.56%     
==========================================
  Files        1488     1613     +125     
  Lines       31617    32445     +828     
  Branches     7669     7421     -248     
==========================================
+ Hits        15311    15531     +220     
- Misses      16238    16872     +634     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
ts/components/LoadingSpinnerOverlay.tsx 100.00% <ø> (ø)
ts/components/screens/LoadingScreenContent.tsx 92.30% <ø> (ø)
ts/components/ui/BoxedRefreshIndicator.tsx 100.00% <100.00%> (ø)
ts/components/ui/IOScrollViewWithLargeHeader.tsx 81.25% <100.00%> (ø)
...es/messages/components/Home/DS/MessageListItem.tsx 100.00% <100.00%> (ø)
.../components/MessageDetail/MessageDetailsFooter.tsx 100.00% <100.00%> (ø)
...nts/checkout/screens/WalletPaymentDetailScreen.tsx 81.08% <ø> (+71.99%) ⬆️
.../components/WalletDetailsPaymentMethodSettings.tsx 50.00% <ø> (-16.67%) ⬇️
...fications/components/NotificationPreviewSample.tsx 100.00% <100.00%> (ø)
...ures/services/common/components/ServicesHeader.tsx 100.00% <ø> (ø)
... and 23 more

... and 1641 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5bb6e...56b9d6c. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

@LeleDallas LeleDallas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be working as expected 🎊🎊

‼️ It would be beneficial for other streams to test this PR for broader coverage ‼️

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the comments noted below, the bonus and payment flow has been tested and functions correctly, with behavior aligning to expectations.

@dmnplb dmnplb merged commit 14022a1 into master Nov 22, 2024
12 checks passed
@dmnplb dmnplb deleted the IOAPPX-399-extend-dark-mode-other-screens branch November 22, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Dark mode 🌝 Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants