-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: [IOCOM-1760] Push notification permissions reminder banner #6414
chore: [IOCOM-1760] Push notification permissions reminder banner #6414
Conversation
…ponente-del-banner-e-logica-di-visualizzazione
…ca-di-visualizzazione
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6414 +/- ##
==========================================
- Coverage 48.42% 47.73% -0.70%
==========================================
Files 1488 1607 +119
Lines 31617 32244 +627
Branches 7669 7446 -223
==========================================
+ Hits 15311 15392 +81
- Misses 16238 16810 +572
+ Partials 68 42 -26
... and 1657 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…ca-di-visualizzazione
…zzazione' of https://github.com/pagopa/io-app into IOCOM-1760-ui-componente-del-banner-e-logica-di-visualizzazione
…ca-di-visualizzazione
…ca-di-visualizzazione
…zzazione' of https://github.com/pagopa/io-app into IOCOM-1760-ui-componente-del-banner-e-logica-di-visualizzazione
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Short description
addition of said banner with its logic
List of changes proposed in this pull request
How to test
set the banner's visibility to
true
in theLANDING_SCREEN_BANNERS_ENABLED_MAP
, then using the dev-server, make sure that in the occasion where:the push notification banner is rendered as shown in the screenshot.
also make sure that if any of those occasions fails, the banner is not rendered.