Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [IOCOM-1760] Push notification permissions reminder banner #6414

Merged

Conversation

forrest57
Copy link
Contributor

@forrest57 forrest57 commented Nov 18, 2024

Short description

addition of said banner with its logic

List of changes proposed in this pull request

  • required I18n
  • required selectors and state entry
  • PushNotificationBanner component
  • addition of said component to the LandingScreenBannerMap
  • tests

How to test

set the banner's visibility to true in the LANDING_SCREEN_BANNERS_ENABLED_MAP, then using the dev-server, make sure that in the occasion where:

  • the user has not done a full login this session (SPID/CIE)
  • notifications are disabled
  • no system prompt has been shown for the push notification permissions

the push notification banner is rendered as shown in the screenshot.

also make sure that if any of those occasions fails, the banner is not rendered.

@pagopa-github-bot pagopa-github-bot changed the title [IOCOM-1760] push notification permissions reminder banner chore: [IOCOM-1760] Push notification permissions reminder banner Nov 18, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 18, 2024

Affected stories

  • ⚙️ IOCOM-1760: UI componente del banner e logica di visualizzazione
    subtask of
    • 🌟 IOCOM-1744: Banner di ingaggio in INBOX messaggi

Generated by 🚫 dangerJS against b0fc126

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.73%. Comparing base (4f204b4) to head (6d877b5).
Report is 744 commits behind head on master.

Files with missing lines Patch % Lines
...ScreenMultiBanner/utils/landingScreenBannerMap.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6414      +/-   ##
==========================================
- Coverage   48.42%   47.73%   -0.70%     
==========================================
  Files        1488     1607     +119     
  Lines       31617    32244     +627     
  Branches     7669     7446     -223     
==========================================
+ Hits        15311    15392      +81     
- Misses      16238    16810     +572     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
...tifications/components/PushNotificationsBanner.tsx 100.00% <100.00%> (ø)
.../sagas/profileAndSystemNotificationsPermissions.ts 100.00% <100.00%> (ø)
...res/pushNotifications/store/actions/environment.ts 100.00% <100.00%> (ø)
...es/pushNotifications/store/reducers/environment.ts 100.00% <100.00%> (ø)
...eatures/pushNotifications/store/selectors/index.ts 100.00% <100.00%> (ø)
...ScreenMultiBanner/utils/landingScreenBannerMap.tsx 50.00% <0.00%> (ø)

... and 1657 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3394b28...6d877b5. Read the comment docs.

---- 🚨 Try these New Features:

…zzazione' of https://github.com/pagopa/io-app into IOCOM-1760-ui-componente-del-banner-e-logica-di-visualizzazione
…zzazione' of https://github.com/pagopa/io-app into IOCOM-1760-ui-componente-del-banner-e-logica-di-visualizzazione
Copy link
Contributor

@Vangaorth Vangaorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@forrest57 forrest57 merged commit 5b4bb16 into master Nov 20, 2024
11 checks passed
@forrest57 forrest57 deleted the IOCOM-1760-ui-componente-del-banner-e-logica-di-visualizzazione branch November 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants