-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-435] Improve overall UI typography + Update io-app-design-system
to 4.0.1
#6422
Open
dmnplb
wants to merge
51
commits into
master
Choose a base branch
from
IOAPPX-435-improve-typography-new-UI
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,590
−1,661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
New visual language and reduction of previous UI clutter
label
Nov 19, 2024
pagopa-github-bot
changed the title
[IOAPPX-435] Improve overall UI typography
chore(Cross): [IOAPPX-435] Improve overall UI typography
Nov 19, 2024
Affected stories
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR improves overall UI typography.
List of changes proposed in this pull request
io-app-design-system
to the new major4.0.1
versionHeaderFirstLevel
to make the title bolderBold
with theSemibold
styleServicesHeader
componentMessageListItem
Chip
typographic style withLabelMini
Label
typographic style withBody
LabelSmall
typographic style with the newBodySmall
CIEIdWizard
)Note
For the reviewers: the default weight of
LabelSmall
wasSemibold
, while the default weight forBodySmall
isRegular
. That's whyLabelSmall
set without theweight
prop was replaced byBodySmall
with theweight
prop set toSemibold
. The same should happen to theLabel
typographic stylePreview
Related PRs
IOText
to accept any numeric value assize
io-app-design-system#361How to test
Check each DS component and navigate through the app to check if everything is OK