Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-435] Improve overall UI typography + Update io-app-design-system to 4.0.1 #6422

Open
wants to merge 51 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Nov 19, 2024

Short description

This PR improves overall UI typography.

List of changes proposed in this pull request

  • Update io-app-design-system to the new major 4.0.1 version
  • Update font weight in the HeaderFirstLevel to make the title bolder
  • Improve Strong markdown style by replacing Bold with the Semibold style
  • Decrease font weight of the subtitle in the ServicesHeader component
  • Improve formatting of the MessageListItem
  • Replace removed Chip typographic style with LabelMini
  • Replace removed Label typographic style with Body
  • Replace removed LabelSmall typographic style with the new BodySmall
  • [extra] Fix typo in the English locale (CIEIdWizard)

Note

For the reviewers: the default weight of LabelSmall was Semibold, while the default weight for BodySmall is Regular. That's why LabelSmall set without the weight prop was replaced by BodySmall with the weight prop set to Semibold. The same should happen to the Label typographic style

Preview

Actual UI New UI
Simulator Screenshot - iPhone 16 Pro - 2024-11-21 at 11 47 43 Simulator Screenshot - iPhone 16 Pro - 2024-11-21 at 11 52 44

Related PRs

How to test

Check each DS component and navigate through the app to check if everything is OK

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Nov 19, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-435] Improve overall UI typography chore(Cross): [IOAPPX-435] Improve overall UI typography Nov 19, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 19, 2024

Affected stories

  • ⚙️ IOAPPX-435: Miglioramento generale della tipografia
    subtask of

Generated by 🚫 dangerJS against d8c7b3b

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 43.33333% with 17 lines in your changes missing coverage. Please review.

Project coverage is 47.70%. Comparing base (4f204b4) to head (d8c7b3b).
Report is 809 commits behind head on master.

Files with missing lines Patch % Lines
...s/fims/singleSignOn/components/FimsPrivacyInfo.tsx 0.00% 2 Missing ⚠️
ts/features/design-system/DesignSystem.tsx 0.00% 1 Missing ⚠️
ts/features/design-system/core/DSNumberPad.tsx 0.00% 1 Missing ⚠️
ts/features/design-system/navigation/navigator.tsx 0.00% 1 Missing ⚠️
ts/features/fci/components/InfoScreenComponent.tsx 50.00% 1 Missing ⚠️
...s/fims/singleSignOn/components/FimsSuccessBody.tsx 0.00% 1 Missing ⚠️
...dpay/details/components/InitiativeRulesInfoBox.tsx 0.00% 1 Missing ⚠️
...nboarding/screens/BoolValuePrerequisitesScreen.tsx 0.00% 1 Missing ⚠️
...boarding/screens/MultiValuePrerequisitesScreen.tsx 0.00% 1 Missing ⚠️
...trustmark/screens/ItwCredentialTrustmarkScreen.tsx 0.00% 1 Missing ⚠️
... and 6 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6422      +/-   ##
==========================================
- Coverage   48.42%   47.70%   -0.73%     
==========================================
  Files        1488     1576      +88     
  Lines       31617    32246     +629     
  Branches     7669     7351     -318     
==========================================
+ Hits        15311    15383      +72     
- Misses      16238    16822     +584     
+ Partials       68       41      -27     
Files with missing lines Coverage Δ
ts/components/AppVersion.tsx 100.00% <ø> (+50.00%) ⬆️
ts/components/BonusCard/BonusCard.tsx 93.93% <ø> (-2.36%) ⬇️
ts/components/IOMarkdown/renderRules.tsx 67.44% <ø> (ø)
ts/components/debug/DebugPrettyPrint.tsx 59.09% <ø> (ø)
ts/components/ui/BannerErrorState.tsx 9.67% <ø> (ø)
ts/components/ui/IOScrollViewWithLargeHeader.tsx 81.25% <100.00%> (ø)
...atures/barcode/components/CameraPermissionView.tsx 100.00% <ø> (ø)
ts/features/bonus/cgn/components/CgnCard.tsx 91.66% <ø> (-8.34%) ⬇️
ts/features/bonus/cgn/components/CgnCardStatus.tsx 100.00% <100.00%> (ø)
...nus/cgn/components/merchants/CgnModuleDiscount.tsx 88.88% <ø> (ø)
... and 69 more

... and 1633 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b268af...d8c7b3b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants