chore(Cross): [IOAPPX-434] Update IconApp iOS assets to remove alpha channel and fix App Store issue
#6451
+0
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmnplb
added
the
Design System
dmnplb
requested review from
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
dmnplb
changed the title
IconApp iOS assets with removal of alpha channelIconApp iOS assets to remove alpha channel and fix App Store issue
pagopa-github-bot
changed the title
IconApp iOS assets to remove alpha channel and fix App Store issueIconApp iOS assets to remove alpha channel and fix App Store issue
Affected stories
|
CrisTofani
approved these changes
Nov 25, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6451 +/- ##
==========================================
- Coverage 48.42% 47.84% -0.59%
==========================================
Files 1488 1621 +133
Lines 31617 32543 +926
Branches 7669 7482 -187
==========================================
+ Hits 15311 15570 +259
- Misses 16238 16919 +681
+ Partials 68 54 -14 see 1680 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
dmnplb
added a commit
that referenced
this pull request
Nov 26, 2024
…ection (#6458) ## Short description This PR removes dark mode app icon to try to fix build rejection. ### Related PRs * #6415 * #6451 ## How to test N/A Co-authored-by: Cristiano Tofani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR updates the
IconAppiOS assets, introduced in the PR #6415, to fix the App Store Connect issue. The previous assets incorrectly included an alpha channel even when there was no transparent layer, as you can see in the attached screenshot:List of changes proposed in this pull request
sRGBcolor profile to all the iconsHow to test
Try to build the app with App Store Connect and pray 🙏