Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-579] Add hub-spid-login for io web #654

Merged
merged 14 commits into from
Aug 9, 2023
Merged

[#IOPID-579] Add hub-spid-login for io web #654

merged 14 commits into from
Aug 9, 2023

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Aug 7, 2023 •
edited
Loading

List of changes

  • Add app_service, redis, subnets to deploy a new hub-spid-login for IO Web
  • Add new APIM product and API for hub-spid-login routing

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@gquadrati gquadrati temporarily deployed to prod-runner August 7, 2023 18:27 — with GitHub Actions Inactive
@gquadrati gquadrati changed the base branch from main to IOPID-598--add-ioweb-app-domain August 7, 2023 18:28
@gquadrati gquadrati temporarily deployed to prod-runner August 7, 2023 18:28 — with GitHub Actions Inactive
@gquadrati gquadrati force-pushed the IOPID-598--add-ioweb-app-domain branch from cfc9f5a to 8e43ee8 Compare August 7, 2023 18:29
@gquadrati gquadrati temporarily deployed to prod-runner August 7, 2023 18:30 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 7, 2023 18:30 — with GitHub Actions Inactive
@gquadrati gquadrati force-pushed the IOPID-579--add-hub-spid-login branch from c90b1ff to 32437b0 Compare August 7, 2023 18:34
@gquadrati gquadrati temporarily deployed to prod-runner August 7, 2023 18:34 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 7, 2023 18:36 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 8, 2023 07:02 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 8, 2023 07:04 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 8, 2023 08:31 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 8, 2023 08:33 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 8, 2023 09:50 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 8, 2023 09:54 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 9, 2023 09:27 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 9, 2023 09:52 — with GitHub Actions Inactive
@arcogabbo arcogabbo marked this pull request as ready for review August 9, 2023 10:22
@arcogabbo arcogabbo requested a review from a team August 9, 2023 10:22
@arcogabbo arcogabbo requested review from a team as code owners August 9, 2023 10:22
arcogabbo
arcogabbo previously approved these changes Aug 9, 2023
View reviewed changes
@gquadrati gquadrati temporarily deployed to prod-runner August 9, 2023 10:23 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner August 9, 2023 10:31 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Aug 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati temporarily deployed to prod-runner August 9, 2023 13:03 — with GitHub Actions Inactive
@gquadrati gquadrati merged commit e272ab9 into main Aug 9, 2023
5 of 7 checks passed
@gquadrati gquadrati deleted the IOPID-579--add-hub-spid-login branch August 9, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldisaro michaeldisaro michaeldisaro approved these changes

@arcogabbo arcogabbo arcogabbo left review comments

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

@BurnedMarshal BurnedMarshal Awaiting requested review from BurnedMarshal BurnedMarshal is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
status: applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gquadrati @michaeldisaro @arcogabbo