Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#IOPID-279] Link storage to fn-fast-login #663

Merged
merged 2 commits into from
Sep 1, 2023

Conversation

BurnedMarshal
Copy link
Contributor

List of changes

Add a data into citizen_auth to refers common storage.
Add new ENV var in fn-fast-login with the connection string to the storage.

Motivation and context

The data can be used only after the resource is created.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information


If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@BurnedMarshal BurnedMarshal requested a review from a team September 1, 2023 15:16
@BurnedMarshal BurnedMarshal requested review from a team as code owners September 1, 2023 15:16
@BurnedMarshal BurnedMarshal temporarily deployed to prod-runner September 1, 2023 15:16 — with GitHub Actions Inactive
@BurnedMarshal BurnedMarshal temporarily deployed to prod-ci September 1, 2023 15:17 — with GitHub Actions Inactive
@BurnedMarshal BurnedMarshal temporarily deployed to prod-runner September 1, 2023 15:18 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@BurnedMarshal BurnedMarshal temporarily deployed to prod-ci September 1, 2023 15:19 — with GitHub Actions Inactive
@BurnedMarshal BurnedMarshal temporarily deployed to prod-runner September 1, 2023 15:23 — with GitHub Actions Inactive
Copy link
Contributor

@arcogabbo arcogabbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BurnedMarshal BurnedMarshal merged commit 2bf6b5f into main Sep 1, 2023
6 of 7 checks passed
@BurnedMarshal BurnedMarshal deleted the IOPID-279-link-storage-to-lv-func branch September 1, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants