Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing private endpoint to iopweuiowebspidlogsst #685

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: Add missing private endpoint to iopweuiowebspidlogsst #685

merged 2 commits into from
Sep 25, 2023

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Sep 22, 2023 •
edited
Loading

List of changes

  • Add missing private endpoint to iopweuiowebspidlogsst, to allow gh action to access/edit containers

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@gquadrati gquadrati temporarily deployed to prod-runner September 22, 2023 16:24 — with GitHub Actions Inactive
@gquadrati gquadrati changed the title Fix missing private endpoint to iopweuiowebspidlogsst fix: Add missing private endpoint to iopweuiowebspidlogsst Sep 22, 2023
@gquadrati gquadrati temporarily deployed to prod-runner September 22, 2023 16:25 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 22, 2023 16:26 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 22, 2023 16:26 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 22, 2023 16:29 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 22, 2023 16:29 — with GitHub Actions Inactive
@arcogabbo arcogabbo marked this pull request as ready for review September 25, 2023 07:35
@arcogabbo arcogabbo requested a review from a team September 25, 2023 07:35
@arcogabbo arcogabbo requested review from a team as code owners September 25, 2023 07:35
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:00 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 25, 2023 08:01 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:04 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:14 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati temporarily deployed to prod-ci September 25, 2023 08:15 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:16 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:16 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:16 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 25, 2023 08:17 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 25, 2023 08:17 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 25, 2023 08:17 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:18 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:19 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:19 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 25, 2023 08:19 — with GitHub Actions Inactive
@gquadrati gquadrati merged commit e640a73 into main Sep 25, 2023
16 checks passed
@gquadrati gquadrati deleted the fix-missing-private-conn-storage branch September 25, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

@Krusty93 Krusty93 Awaiting requested review from Krusty93 Krusty93 is a code owner automatically assigned from pagopa/io-backend-contributors

@iwoak iwoak Awaiting requested review from iwoak iwoak is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @arcogabbo