Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IOPID-875] IO-BFF API group definition #692

Merged
merged 12 commits into from
Sep 29, 2023
Merged

[IOPID-875] IO-BFF API group definition #692

merged 12 commits into from
Sep 29, 2023

Conversation

Krusty93
Copy link
Contributor

@Krusty93 Krusty93 commented Sep 27, 2023 •
edited
Loading

List of changes

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 14:52 — with GitHub Actions Inactive
@Krusty93 Krusty93 changed the title bff api group definition [IOPID-875] IO-BFF API group definition Sep 27, 2023
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 14:54 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 14:54 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 14:57 — with GitHub Actions Inactive
@Krusty93 Krusty93 force-pushed the IOPID-875-infra-policy-di-apim-per-il-routing-verso-bff-di-io-web branch from 06e076e to cc2414d Compare September 27, 2023 15:16
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:16 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:16 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:16 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:16 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:16 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 27, 2023 15:17 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 27, 2023 15:17 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 27, 2023 15:17 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 27, 2023 15:17 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 27, 2023 15:17 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:21 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:21 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:21 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:22 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:22 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:27 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 27, 2023 15:27 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 27, 2023 15:31 — with GitHub Actions Inactive
gquadrati
gquadrati requested changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@gquadrati gquadrati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small fix, thanks!

src/domains/ioweb-app/07_apim_v2.tf Outdated Show resolved Hide resolved
@Krusty93 Krusty93 temporarily deployed to prod-runner September 28, 2023 12:49 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 28, 2023 12:51 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 28, 2023 12:55 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 28, 2023 12:59 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-ci September 28, 2023 13:00 — with GitHub Actions Inactive
@Krusty93 Krusty93 temporarily deployed to prod-runner September 28, 2023 13:03 — with GitHub Actions Inactive
@Krusty93 Krusty93 marked this pull request as ready for review September 28, 2023 13:08
@Krusty93 Krusty93 requested a review from a team September 28, 2023 13:08
@Krusty93 Krusty93 requested review from a team as code owners September 28, 2023 13:08
@gquadrati gquadrati temporarily deployed to prod-runner September 29, 2023 06:39 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci September 29, 2023 06:40 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 29, 2023 06:44 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 29, 2023 09:32 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Sep 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati temporarily deployed to prod-ci September 29, 2023 09:32 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner September 29, 2023 09:36 — with GitHub Actions Inactive
@gquadrati gquadrati merged commit c8fc1ce into main Sep 29, 2023
7 checks passed
@gquadrati gquadrati deleted the IOPID-875-infra-policy-di-apim-per-il-routing-verso-bff-di-io-web branch September 29, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gquadrati gquadrati gquadrati approved these changes

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

@StefanoDoc StefanoDoc Awaiting requested review from StefanoDoc StefanoDoc is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Krusty93 @gquadrati @arcogabbo