Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#IOPID-945] fix: magic link base url #707

Merged
merged 4 commits into from
Oct 6, 2023
Merged

[#IOPID-945] fix: magic link base url #707

merged 4 commits into from
Oct 6, 2023

Conversation

gquadrati
Copy link
Contributor

@gquadrati gquadrati commented Oct 5, 2023 •
edited
Loading

List of changes

fix magic link base url
fix CDN 404 link

Motivation and context

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Env to apply

  • DEV
  • UAT
  • PROD

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

Does this introduce an unwanted change on infrastructure? Check terraform plan execution result

  • Yes
  • No

Other information

If PR is partially applied, why? (reserved to mantainers)

How to apply

After PR is approved

  1. run deploy pipeline from Azure DevOps io-platform-iac-projects
  2. select PR branch
  3. wait for approval

@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 5, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 5, 2023 13:10 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 5, 2023 13:10 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 5, 2023 13:10 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 5, 2023 13:10 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:13 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:13 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:13 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:13 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 13:13 — with GitHub Actions Inactive
@gquadrati gquadrati marked this pull request as ready for review October 5, 2023 13:16
@gquadrati gquadrati requested a review from a team October 5, 2023 13:16
@gquadrati gquadrati requested review from a team as code owners October 5, 2023 13:16
arcogabbo
arcogabbo previously approved these changes Oct 5, 2023
View reviewed changes
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 15:32 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 5, 2023 15:33 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 5, 2023 15:36 — with GitHub Actions Inactive
@arcogabbo arcogabbo temporarily deployed to prod-runner October 6, 2023 12:37 — with GitHub Actions Inactive
@arcogabbo arcogabbo temporarily deployed to prod-ci October 6, 2023 12:38 — with GitHub Actions Inactive
@arcogabbo arcogabbo temporarily deployed to prod-runner October 6, 2023 12:41 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 6, 2023 13:02 — with GitHub Actions Inactive
@sonarcloud
Copy link

sonarcloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gquadrati gquadrati temporarily deployed to prod-ci October 6, 2023 13:02 — with GitHub Actions Inactive
@gquadrati gquadrati changed the title [#IOPID-928] fix: magic link base url [#IOPID-945] fix: magic link base url Oct 6, 2023
@gquadrati gquadrati temporarily deployed to prod-runner October 6, 2023 13:04 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 6, 2023 13:05 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 6, 2023 13:06 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 6, 2023 13:07 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 6, 2023 13:08 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-ci October 6, 2023 13:09 — with GitHub Actions Inactive
@gquadrati gquadrati temporarily deployed to prod-runner October 6, 2023 13:11 — with GitHub Actions Inactive
@arcogabbo arcogabbo mentioned this pull request Oct 6, 2023
Closed
10 tasks
@arcogabbo arcogabbo merged commit 7b5d4ed into main Oct 6, 2023
13 checks passed
@arcogabbo arcogabbo deleted the IOPID-928--fix-magic-link-base-path branch October 6, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arcogabbo arcogabbo arcogabbo approved these changes

@diegolagospagopa diegolagospagopa Awaiting requested review from diegolagospagopa

@giamma1295 giamma1295 Awaiting requested review from giamma1295 giamma1295 is a code owner automatically assigned from pagopa/io-backend-contributors

@Garma00 Garma00 Awaiting requested review from Garma00 Garma00 is a code owner automatically assigned from pagopa/io-backend-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gquadrati @arcogabbo