Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [SIW-1681] Change pattern to find the CIE authentication link #142

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

gispada
Copy link
Collaborator

@gispada gispada commented Sep 26, 2024

List of Changes

  • Changed the pattern to find the CIE authentication link (a element) to "lettura carta"
  • Set the a text to lower case before matching the pattern

Motivation and Context

The CIE + PIN authentication method stopped working after the link text was changed in the CIE web app.

How Has This Been Tested?

Tested on io-app to get a wallet instance.

@gispada gispada requested a review from a team as a code owner September 26, 2024 10:59
@github-actions github-actions bot added the fix label Sep 26, 2024
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LazyAfternoons LazyAfternoons added this pull request to the merge queue Sep 26, 2024
Merged via the queue into master with commit a01481e Sep 26, 2024
7 checks passed
@LazyAfternoons LazyAfternoons deleted the SIW-1681-cie-auth-button-text branch September 26, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants