Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [SIW-1632] Reuse the Wallet Instance Attestation in the example app #144

Conversation

mastro993
Copy link
Contributor

@mastro993 mastro993 commented Sep 27, 2024

List of Changes

This PR removes the need to get a new Wallet Instance Attestation every time there is a credential issuance.
Once the WIA is obtained, it is stored and persisted to the device via Secure Storage and then used for the credential issuance. The WIA is obtained again only when it expires.
This PR also introduces Secure Storage for WIA, PID and Credentials persistance.

Motivation and Context

Since new WIA requests on Android requires a Play Integrity API call, this change is required to reduce the Play Integrity API usage.

How Has This Been Tested?

Run the example app and check that the WIA is requested only once or when it is expired

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@LazyAfternoons LazyAfternoons changed the title [SIW-1632] Reuse the Wallet Instance Attestation in the example app chore: [SIW-1632] Reuse the Wallet Instance Attestation in the example app Sep 30, 2024
@github-actions github-actions bot added the chore label Sep 30, 2024
Copy link
Contributor

@LazyAfternoons LazyAfternoons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mastro993 mastro993 added this pull request to the merge queue Oct 4, 2024
Merged via the queue into master with commit 189cce5 Oct 4, 2024
7 checks passed
@mastro993 mastro993 deleted the SIW-1632-io-react-native-wallet-riutilizzo-della-wallet-instance-nei-flussi branch October 4, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants