-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [SIW-1844] Add trustmark generation functions #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
src/credential/trustmark/__tests__/get-credential-trustmark.test.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 🔥
Remember to increase the minor version in package.json before release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it's perfect!
List of Changes
getCredentialTrustmarkJwt
function, which returns the credential's trustmark JWTMotivation and Context
This approach addresses vulnerabilities in the previous static QR code implementation.
This new TrustMark implementation binds the QR code to the specific credential being verified, preventing QR code swapping and ensuring unique, tamper-proof authentication. It uses a signed JWT with a short validity period for enhanced security.
The trustmark JWT can be obtained using the following function, exported from
Credential.Trustmark
:How Has This Been Tested?
Tested the Trustmark generation using the example app
Screenshots (if appropriate):
ScreenRecording_11-16-2024.12-25-32_1.MP4
Checklist: