feat: [SIW-352] Presentation submission #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grausof
requested changes
Aug 3, 2023
src/rp/index.ts
Outdated
| const [, vc_scope] = requestObj.payload.scope; | ||
| const presentation_submission = { | ||
| definition_id: "32f54163-7166-48f1-93d8-ff217bdb0653", | ||
| id: "04a98be3-7fb0-4cf5-af9a-31579c8b0e7d", |
There was a problem hiding this comment.
This value should be randomized
Suggested change
| id: "04a98be3-7fb0-4cf5-af9a-31579c8b0e7d", | |
| id: `${uuid.v4()}`, |
There was a problem hiding this comment.
uuid.v4() is of type number[]. I think you have to use a string. Also you imported uuid twice
src/sd-jwt/__test__/index.test.ts
Outdated
|
|
||
| expect(fn).toThrow(); | ||
| expect(fn).rejects.toBe({}); |
There was a problem hiding this comment.
Check code review warning: Async assertions must be awaited or returned
balanza
force-pushed
the
SIW-352--presentation-submission
branch
from
c2ef778
to
04224c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Changes
presentation_submissionon authorization response payloadMotivation and Context
Satisfy the specification given in https://italia.github.io/eudi-wallet-it-docs/v0.4.1/en/relying-party-solution.html
How Has This Been Tested?
Screenshots (if appropriate):
Checklist: