Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PAGOPA-1164] psp business name #102

Merged
merged 4 commits into from
Aug 24, 2023
Merged

[PAGOPA-1164] psp business name #102

merged 4 commits into from
Aug 24, 2023

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • Added psp business name info to the bundle

Motivation and Context

  • The new information is needed by stakeholders

How Has This Been Tested?

junit and manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli marked this pull request as ready for review August 24, 2023 14:36
@alessio-acitelli alessio-acitelli changed the title [PAGOPA-1164] psp business name: first impl [PAGOPA-1164] psp business name Aug 24, 2023
FedericoRuzzier
FedericoRuzzier approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@FedericoRuzzier FedericoRuzzier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 , update branch and solve conflicts then merge

@alessio-acitelli alessio-acitelli merged commit 2831b85 into main Aug 24, 2023
7 checks passed
@alessio-acitelli alessio-acitelli deleted the PAGOPA-1164-psp-business-name branch August 24, 2023 15:27
@sonarcloud
Copy link

sonarcloud bot commented Aug 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@alessio-acitelli alessio-acitelli temporarily deployed to dev August 24, 2023 15:30 — with GitHub Actions Inactive
@alessio-acitelli alessio-acitelli temporarily deployed to dev August 24, 2023 15:30 — with GitHub Actions Inactive
@alessio-acitelli alessio-acitelli temporarily deployed to dev August 24, 2023 15:34 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FedericoRuzzier FedericoRuzzier FedericoRuzzier approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
size/small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @FedericoRuzzier @pagopa-github-bot