Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat:[PagoPa-1147] AMEX filter #99

Merged
merged 9 commits into from
Aug 22, 2023
Merged

feat:[PagoPa-1147] AMEX filter #99

merged 9 commits into from
Aug 22, 2023

Conversation

alessio-acitelli
Copy link
Collaborator

List of Changes

  • added management for AMEX payments

Motivation and Context

  • new business request

How Has This Been Tested?

Junit and manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@alessio-acitelli alessio-acitelli added enhancement New feature or request minor labels Aug 8, 2023
@alessio-acitelli alessio-acitelli changed the title Pagopa 1147 amex filter feat:[PagoPa-1147] AMEX filter Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Comment this PR with update_code to update openapi.json and format the code. Consider to use pre-commit to format the code.

@alessio-acitelli
Copy link
Collaborator Author

update_code

@alessio-acitelli alessio-acitelli marked this pull request as ready for review August 8, 2023 13:54
pasqualespica
pasqualespica requested changes Aug 21, 2023
View reviewed changes
Copy link
Contributor

@pasqualespica pasqualespica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, but remove key

src/main/resources/application-dev.properties Outdated
azure.cosmos.database=db

# Storage account config
azure.storage.connection=DefaultEndpointsProtocol=https;AccountName=pagopadweuafmsa;AccountKey=RRDygFmNKKHpX+icQN4F3UdNzaoCgbbS4K8QDjFq0vJUCUKPpBv2DykLYm22OlqsIbZCPYNQJdEO+AStoX9jzw==;EndpointSuffix=core.windows.net
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove it

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

83.3% 83.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@pasqualespica pasqualespica merged commit 5e9954c into main Aug 22, 2023
11 checks passed
@pasqualespica pasqualespica deleted the PAGOPA-1147-amex-filter branch August 22, 2023 14:39
@pasqualespica pasqualespica temporarily deployed to dev August 22, 2023 14:41 — with GitHub Actions Inactive
@pasqualespica pasqualespica temporarily deployed to dev August 23, 2023 20:56 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pasqualespica pasqualespica pasqualespica approved these changes

Assignees

@alessio-acitelli alessio-acitelli

Labels
enhancement New feature or request minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessio-acitelli @pasqualespica @pagopa-github-bot