generated from pagopa/pn-template-ms-be
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PN-13228 - Create template generator script #10
Open
alessandrogelmi
wants to merge
21
commits into
develop
Choose a base branch
from
feat/PN-13228
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+11,485
−1,178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quality Gate passedIssues Measures |
SarahDonvito
requested changes
Nov 22, 2024
templates-assets/templates/PEC_ValidationContactsRejectBody/index.html
Outdated
Show resolved
Hide resolved
templates-assets/templates/PEC_ValidationContactsSuccessBody/index.html
Outdated
Show resolved
Hide resolved
… into feat/PN-13228
SarahDonvito
requested changes
Nov 25, 2024
SarahDonvito
previously approved these changes
Nov 25, 2024
AndreaCimini90
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In tests we don't manage the error case
AndreaCimini90
requested changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Develop a template generator script that converts MJML files into HTML and generates fully translated HTML templates from them.
List of changes proposed in this pull request
pn-email-templates
How to test
npm run build
target
folder contains a subfolder namedgenerated-templates-assets
, which should include all necessary assets (fonts
,images
,styles
,templates
)