Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SELC-3793] fix: change field name isIpa and isAgentOfPublicService #320

Merged
merged 2 commits into from
Jan 22, 2024
Merged

[SELC-3793] fix: change field name isIpa and isAgentOfPublicService #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
43d3ead
fix: change field name isIpa and isAgentOfPublicService to ipa and ag…
giulia-tremolada Jan 22, 2024
fbb3862
fix: change field name isIpa and isAgentOfPublicService to ipa and ag…
giulia-tremolada Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions app/src/main/resources/swagger/api-docs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3332,7 +3332,9 @@
"type" : "object",
"properties" : {
"agentOfPublicService" : {
"type" : "boolean"
"type" : "boolean",
"description" : "The institution is an agent of a public service",
"example" : false
},
"agentOfPublicServiceNote" : {
"type" : "string",
Expand All @@ -3353,7 +3355,9 @@
"description" : "establishedByRegulatoryProvision Note"
},
"ipa" : {
"type" : "boolean"
"type" : "boolean",
"description" : "The institution is registered on IPA",
"example" : false
},
"ipaCode" : {
"type" : "string",
Expand Down
4 changes: 2 additions & 2 deletions ...java/it/pagopa/selfcare/dashboard/connector/model/institution/AdditionalInformations.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ public class AdditionalInformations {

private boolean belongRegulatedMarket;
private String regulatedMarketNote;
private boolean isIpa;
private boolean ipa;
private String ipaCode;
private boolean establishedByRegulatoryProvision;
private String establishedByRegulatoryProvisionNote;
private boolean isAgentOfPublicService;
private boolean agentOfPublicService;
private String agentOfPublicServiceNote;
private String otherNote;

Expand Down
4 changes: 2 additions & 2 deletions ...rc/test/resources/stubs/ms-core/mappings/getUserInstitutionRelationships_fullyValued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
"additionalInformations" : {
"belongRegulatedMarket" : true,
"regulatedMarketNote" : "string",
"isIpa" : true,
"ipa" : true,
"ipaCode" : "string",
"establishedByRegulatoryProvision" : true,
"establishedByRegulatoryProvisionNote" : "string",
"isAgentOfPublicService" : true,
"agentOfPublicService" : true,
"agentOfPublicServiceNote" : "string",
"otherNote" : "string"
},
Expand Down
4 changes: 2 additions & 2 deletions ...t/src/test/resources/stubs/party-management/mappings/getRelationshipById_fullyValued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@
"additionalInformations" : {
"belongRegulatedMarket" : true,
"regulatedMarketNote" : "string",
"isIpa" : true,
"ipa" : true,
"ipaCode" : "string",
"establishedByRegulatoryProvision" : true,
"establishedByRegulatoryProvisionNote" : "string",
"isAgentOfPublicService" : true,
"agentOfPublicService" : true,
"agentOfPublicServiceNote" : "string",
"otherNote" : "string"
},
Expand Down
4 changes: 2 additions & 2 deletions ...t/resources/stubs/party-process/mappings/getUserInstitutionRelationships_fullyValued.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@
"additionalInformations" : {
"belongRegulatedMarket" : true,
"regulatedMarketNote" : "string",
"isIpa" : true,
"ipa" : true,
"ipaCode" : "string",
"establishedByRegulatoryProvision" : true,
"establishedByRegulatoryProvisionNote" : "string",
"isAgentOfPublicService" : true,
"agentOfPublicService" : true,
"agentOfPublicServiceNote" : "string",
"otherNote" : "string"
},
Expand Down
8 changes: 4 additions & 4 deletions ...ain/java/it/pagopa/selfcare/dashboard/web/model/onboarding/OnboardingRequestResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,8 @@ public static class AdditionalInformations{
@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.regulatedMarketNote}")
private String regulatedMarketNote;

@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.isIpa}")
private boolean isIpa;
@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.ipa}")
private boolean ipa;

@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.ipaCode}")
private String ipaCode;
Expand All @@ -112,8 +112,8 @@ public static class AdditionalInformations{
@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.establishedByRegulatoryProvisionNote}")
private String establishedByRegulatoryProvisionNote;

@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.isAgentOfPublicService}")
private boolean isAgentOfPublicService;
@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.agentOfPublicService}")
private boolean agentOfPublicService;

@ApiModelProperty(value = "${swagger.dashboard.institutions.model.additionalInformations.agentOfPublicServiceNote}")
private String agentOfPublicServiceNote;
Expand Down
4 changes: 2 additions & 2 deletions web/src/main/resources/swagger/swagger_en.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,11 +178,11 @@ swagger.dashboard.institutions.partners=Retrieve institution's delegations
swagger.dashboard.institutions.delegations=Retrieve list of delegation using to
swagger.dashboard.institutions.model.additionalInformations.belongRegulatedMarket=The institution belongs to a regulated market
swagger.dashboard.institutions.model.additionalInformations.regulatedMarketNote=regulatedMarket Note
swagger.dashboard.institutions.model.additionalInformations.isIpa=The institution is registered on IPA
swagger.dashboard.institutions.model.additionalInformations.ipa=The institution is registered on IPA
swagger.dashboard.institutions.model.additionalInformations.ipaCode=IPA code
swagger.dashboard.institutions.model.additionalInformations.establishedByRegulatoryProvision=The institution is a company established by a regulatory provision
swagger.dashboard.institutions.model.additionalInformations.establishedByRegulatoryProvisionNote=establishedByRegulatoryProvision Note
swagger.dashboard.institutions.model.additionalInformations.isAgentOfPublicService=The institution is an agent of a public service
swagger.dashboard.institutions.model.additionalInformations.agentOfPublicService=The institution is an agent of a public service
swagger.dashboard.institutions.model.additionalInformations.agentOfPublicServiceNote=agentOfPublicService Note
swagger.dashboard.institutions.model.additionalInformations.otherNote=Other note
swagger.dashboard.institutions.model.additionalInformations=Institution's additional informations
Loading