Fixes possible bug, extends block 3, fixes #202 #207
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepares const to extend decoding of system status block 3
|
Unable to find the run test failure bug |
pail23
reviewed
Feb 29, 2024
| """Read the system state values from the ISG.""" | ||
| result = {} | ||
| inverter_data = self.read_input_registers(slave=1, address=2500, count=47) | ||
| inverter_data = self.read_input_registers(slave=1, address=2500, count=23) |
There was a problem hiding this comment.
I propose not to read twice on the modbus since this reduces the performance. When you need to split the function, I propose to do that after this line
There was a problem hiding this comment.
Unable to fix in a proper way. I accept suggestions.
Padanian
changed the title
pail23
added a commit
that referenced
this pull request
Mar 8, 2024
|
@Padanian I took the new entities from this PR and merged them into the main branch. I decided to live with the "high complexity" and ignore the C901 since spliting will not make it simpler |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes possible bug concerning decoding of circulation pump
Prepares const to extend decoding of system status block 3