fix: restore ability to use occam with extensions #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent change to support multi-arch for buildpacks brokle occam for extensions. This was because extensions were being built with "pack buildpack package" which seems to work for extensions if a tgz is passed in but not an expanded directory. Update to use "pack extension package" for extensions instead. Unfortunately pack does not yet seem to support multi-arch for extensions so we'll have to add the --target option for extensions after that has been added. Signed-off-by: Michael Dawson <[email protected]>
ForestEckhardt
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Recent change to support multi-arch for buildpacks brokle occam for extensions. This was because extensions were being built with "pack buildpack package" which seems to work for extensions if a tgz is passed in but not an expanded directory.
Update to use "pack extension package" for extensions instead. Unfortunately pack does not yet seem to support multi-arch for extensions so we'll have to add the --target option for extensions after that has been added.
Use Cases
Checklist