Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: respect existing RAILS_ENV and SECRET_KEY_BASE #342

Merged
merged 5 commits into from
Jun 28, 2023
Merged

feat: respect existing RAILS_ENV and SECRET_KEY_BASE #342

merged 5 commits into from
Jun 28, 2023

Conversation

josegonzalez
Copy link
Contributor

Summary

This change allows users to set alternative values for RAILS_ENV and SECRET_KEY_BASE when precompiling assets.

Closes #200

Use Cases

I want to compile my dependencies with RAILS_ENV=staging and I couldn't before.

Checklist

  • I have viewed, signed, and submitted the Contributor License Agreement.
  • I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
  • I have added an integration test, if necessary.
  • I have reviewed the styleguide for guidance on my code quality.
  • I'm happy with the commit history on this PR (I have rebased/squashed as needed).

@josegonzalez
feat: respect existing RAILS_ENV and SECRET_KEY_BASE
ff9acca 
This change allows users to set alternative values for RAILS_ENV and SECRET_KEY_BASE when precompiling assets.

Closes paketo-buildpacks#200
@josegonzalez josegonzalez requested a review from a team as a code owner June 20, 2023 23:41
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 20, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@josegonzalez
Copy link
Contributor Author

The Individual CLA option is not enabled for this project. Please to your administrator to enable the Individual CLA option for this project.

Doesn't seem like I can sign the CLA?

@christopherclark
Copy link
Member

@josegonzalez I opened a ticket with LF IT (with the link in the check above) - and they're surprised by this. Per support ticket, "Can they try clearing their cache or incognito? Maybe provide a screen shot of what they are seeing?"

@josegonzalez
Copy link
Contributor Author

Weird. I clicked it and it gave me the error, then the button went green and I was able to click it. I am no longer able to replicate the issue either :|

@josegonzalez
Copy link
Contributor Author

I signed it though!

@sophiewigmore
Copy link
Member

@josegonzalez the changes here look good to me 👍

@sophiewigmore sophiewigmore added the semver:minor A change requiring a minor version bump label Jun 28, 2023
@sophiewigmore sophiewigmore enabled auto-merge (rebase) June 28, 2023 14:27
@sophiewigmore sophiewigmore merged commit ca9bd37 into paketo-buildpacks:main Jun 28, 2023
@josegonzalez josegonzalez deleted the 200-respect-env branch June 28, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sophiewigmore sophiewigmore sophiewigmore approved these changes

Assignees
No one assigned
Labels
semver:minor A change requiring a minor version bump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RFC 0019: Allow RAILS_ENV to be overridden at build time
3 participants
@josegonzalez @christopherclark @sophiewigmore