Installing node from images.json #203

pacostas · 2024-08-16T15:00:21Z

Summary

This PR selects which node-engine to install based on the node versions that exist on images.json file.

Use Cases

Checklist

I have viewed, signed, and submitted the Contributor License Agreement.
I have linked issue(s) that this PR should close using keywords or the Github UI (See docs)
I have added an integration test, if necessary.
I have reviewed the styleguide for guidance on my code quality.
I'm happy with the commit history on this PR (I have rebased/squashed as needed).

generate_test.go

pacostas · 2024-09-11T09:17:45Z

generate.go

-type DuringBuildPermissions struct {
-	CNB_USER_ID, CNB_GROUP_ID int
-}
-
-//go:embed templates/build.Dockerfile
-var buildDockerfileTemplate string
-
-type BuildDockerfileProps struct {
-	NODEJS_VERSION            uint64
-	CNB_USER_ID, CNB_GROUP_ID int
-	CNB_STACK_ID, PACKAGES    string
-}
-
-//go:embed templates/run.Dockerfile
-var runDockerfileTemplate string
-
-type RunDockerfileProps struct {
-	Source string
-}


It has been moved to utils

pacostas · 2024-09-11T09:18:40Z

generate.go

-func FillPropsToTemplate(properties interface{}, templateString string) (result string, Error error) {
-
-	templ, err := template.New("template").Parse(templateString)
-	if err != nil {
-		return "", err
-	}
-
-	var buf bytes.Buffer
-	err = templ.Execute(&buf, properties)
-	if err != nil {
-		panic(err)
-	}
-
-	return buf.String(), nil
-}
-
-func GetDuringBuildPermissions(filepath string) DuringBuildPermissions {
-
-	defaultPermissions := DuringBuildPermissions{
-		CNB_USER_ID:  DEFAULT_USER_ID,
-		CNB_GROUP_ID: DEFAULT_GROUP_ID,
-	}
-	re := regexp.MustCompile(`cnb:x:(\d+):(\d+)::`)
-
-	etcPasswdFile, err := os.ReadFile(filepath)
-
-	if err != nil {
-		return defaultPermissions
-	}
-	etcPasswdContent := string(etcPasswdFile)
-
-	matches := re.FindStringSubmatch(etcPasswdContent)
-
-	if len(matches) != 3 {
-		return defaultPermissions
-	}
-
-	CNB_USER_ID, err := strconv.Atoi(matches[1])
-
-	if err != nil {
-		return defaultPermissions
-	}
-
-	CNB_GROUP_ID, err := strconv.Atoi(matches[2])
-
-	if err != nil {
-		return defaultPermissions
-	}
-
-	return DuringBuildPermissions{
-		CNB_USER_ID:  CNB_USER_ID,
-		CNB_GROUP_ID: CNB_GROUP_ID,
-	}
-}


It has been moved untouched to utils

pacostas · 2024-09-11T09:19:10Z

generate_test.go

-type RunDockerfileProps struct {
-	Source string
-}
-
-//go:embed templates/run.Dockerfile
-var runDockerfileTemplate string
-
-type BuildDockerfileProps struct {
-	NODEJS_VERSION            uint64
-	CNB_USER_ID, CNB_GROUP_ID int
-	CNB_STACK_ID, PACKAGES    string
-}
-
-//go:embed templates/build.Dockerfile
-var buildDockerfileTemplate string


It has been moved to utils untouched

pacostas · 2024-09-11T09:21:39Z

generate_test.go

-func testFetchingPermissionsFromEtchPasswdFile(t *testing.T, context spec.G, it spec.S) {
-
-	var (
-		Expect = NewWithT(t).Expect
-		tmpDir string
-		path   string
-		err    error
-	)
-
-	context("/etc/passwd exists and has the cnb user", func() {
-
-		it("It should return the permissions specified for the cnb user", func() {
-			tmpDir, err = os.MkdirTemp("", "")
-			Expect(err).NotTo(HaveOccurred())
-
-			path = filepath.Join(tmpDir, "/passwd")
-
-			Expect(os.WriteFile(path, []byte(`root:x:0:0:root:/root:/bin/bash
-bin:x:1:1:bin:/bin:/sbin/nologin
-daemon:x:2:2:daemon:/sbin:/sbin/nologin
-adm:x:3:4:adm:/var/adm:/sbin/nologin
-lp:x:4:7:lp:/var/spool/lpd:/sbin/nologin
-sync:x:5:0:sync:/sbin:/bin/sync
-shutdown:x:6:0:shutdown:/sbin:/sbin/shutdown
-halt:x:7:0:halt:/sbin:/sbin/halt
-mail:x:8:12:mail:/var/spool/mail:/sbin/nologin
-operator:x:11:0:operator:/root:/sbin/nologin
-games:x:12:100:games:/usr/games:/sbin/nologin
-ftp:x:14:50:FTP User:/var/ftp:/sbin/nologin
-cnb:x:1234:2345::/home/cnb:/bin/bash
-nobody:x:65534:65534:Kernel Overflow User:/:/sbin/nologin
-`), 0600)).To(Succeed())
-
-			duringBuilderPermissions := ubinodejsextension.GetDuringBuildPermissions(path)
-
-			Expect(duringBuilderPermissions).To(Equal(
-				ubinodejsextension.DuringBuildPermissions{
-					CNB_USER_ID:  1234,
-					CNB_GROUP_ID: 2345},
-			))
-		})
-	})
-
-	context("/etc/passwd exists and does NOT have the cnb user", func() {
-
-		it("It should return the default permissions", func() {
-			tmpDir, err = os.MkdirTemp("", "")
-			Expect(err).NotTo(HaveOccurred())
-
-			path = filepath.Join(tmpDir, "/passwd")
-
-			Expect(os.WriteFile(path, []byte(`root:x:0:0:root:/root:/bin/bash
-bin:x:1:1:bin:/bin:/sbin/nologin
-daemon:x:2:2:daemon:/sbin:/sbin/nologin
-adm:x:3:4:adm:/var/adm:/sbin/nologin
-lp:x:4:7:lp:/var/spool/lpd:/sbin/nologin
-sync:x:5:0:sync:/sbin:/bin/sync
-shutdown:x:6:0:shutdown:/sbin:/sbin/shutdown
-halt:x:7:0:halt:/sbin:/sbin/halt
-mail:x:8:12:mail:/var/spool/mail:/sbin/nologin
-operator:x:11:0:operator:/root:/sbin/nologin
-games:x:12:100:games:/usr/games:/sbin/nologin
-ftp:x:14:50:FTP User:/var/ftp:/sbin/nologin
-nobody:x:65534:65534:Kernel Overflow User:/:/sbin/nologin
-`), 0600)).To(Succeed())
-
-			duringBuilderPermissions := ubinodejsextension.GetDuringBuildPermissions(path)
-
-			Expect(duringBuilderPermissions).To(Equal(
-				ubinodejsextension.DuringBuildPermissions{
-					CNB_USER_ID:  ubinodejsextension.DEFAULT_USER_ID,
-					CNB_GROUP_ID: ubinodejsextension.DEFAULT_GROUP_ID},
-			))
-		})
-	})
-
-	context("/etc/passwd does NOT exist", func() {
-
-		it("It should return the default permissions", func() {
-			tmpDir, err = os.MkdirTemp("", "")
-			Expect(err).NotTo(HaveOccurred())
-
-			duringBuilderPermissions := ubinodejsextension.GetDuringBuildPermissions(tmpDir)
-
-			Expect(duringBuilderPermissions).To(Equal(
-				ubinodejsextension.DuringBuildPermissions{
-					CNB_USER_ID:  ubinodejsextension.DEFAULT_USER_ID,
-					CNB_GROUP_ID: ubinodejsextension.DEFAULT_GROUP_ID},
-			))
-		})
-	})
-}
-


It has been moved to utils_test untouched

pacostas · 2024-09-11T09:25:23Z

generate_test.go

-		it("Should error in case there are no entries in the buildpack plan.", func() {
-
-			extensionToml, _ := readExtensionTomlTemplateFile()
-
-			cnbDir, err = os.MkdirTemp("", "cnb")
-			Expect(err).NotTo(HaveOccurred())
-			Expect(os.WriteFile(cnbDir+"/extension.toml", []byte(extensionToml), 0600)).To(Succeed())
-
-			entriesTests := []struct {
-				Entries []packit.BuildpackPlanEntry
-			}{
-				{
-					Entries: []packit.BuildpackPlanEntry{},
-				},
-			}
-
-			for _, tt := range entriesTests {
-
-				generateResult, err = generate(packit.GenerateContext{
-					WorkingDir: workingDir,
-					CNBPath:    cnbDir,
-					Plan: packit.BuildpackPlan{
-						Entries: tt.Entries,
-					},
-					Stack: "io.buildpacks.stacks.ubi8",
-				})
-
-				Expect(err).To(HaveOccurred())
-
-			}
-
-		})


Removed as is exactly the same with this test

ubi-nodejs-extension/generate_test.go

Lines 236 to 247 in ac00b6c

it("Node no longer requested in buildplan", func() {

generateResult, err = generate(packit.GenerateContext{

WorkingDir: workingDir,

Plan: packit.BuildpackPlan{

Entries: []packit.BuildpackPlanEntry{},

},

})

Expect(err).To(HaveOccurred())

Expect(generateResult.BuildDockerfile).To(BeNil())

})

}, spec.Sequential())

pacostas · 2024-09-11T09:29:44Z

internal/utils/utils.go

+func fillPropsToTemplate(properties interface{}, templateString string) (result string, Error error) {
+
+	templ, err := template.New("template").Parse(templateString)
+	if err != nil {
+		return "", err
+	}
+
+	var buf bytes.Buffer
+	err = templ.Execute(&buf, properties)
+	if err != nil {
+		panic(err)
+	}
+
+	return buf.String(), nil
+}


moved to utils from generate untouched

pacostas · 2024-09-11T09:31:11Z

structs/structs.go

+package structs
+
+type DuringBuildPermissions struct {
+	CNB_USER_ID, CNB_GROUP_ID int
+}
+
+type BuildDockerfileProps struct {
+	NODEJS_VERSION            uint64
+	CNB_USER_ID, CNB_GROUP_ID int
+	CNB_STACK_ID, PACKAGES    string
+}
+
+type RunDockerfileProps struct {
+	Source string
+}


moved to structs from generate, untouched

pacostas · 2024-09-11T09:31:50Z

internal/utils/utils_test.go

+func testGetDuringBuildPermissions(t *testing.T, context spec.G, it spec.S) {
+
+	var (
+		Expect = NewWithT(t).Expect
+		tmpDir string
+		path   string
+		err    error
+	)
+
+	context("/etc/passwd exists and has the cnb user", func() {
+
+		it("It should return the permissions specified for the cnb user", func() {
+			tmpDir, err = os.MkdirTemp("", "")
+			Expect(err).NotTo(HaveOccurred())
+
+			path = filepath.Join(tmpDir, "/passwd")
+
+			Expect(os.WriteFile(path, []byte(`root:x:0:0:root:/root:/bin/bash
+bin:x:1:1:bin:/bin:/sbin/nologin
+daemon:x:2:2:daemon:/sbin:/sbin/nologin
+adm:x:3:4:adm:/var/adm:/sbin/nologin
+lp:x:4:7:lp:/var/spool/lpd:/sbin/nologin
+sync:x:5:0:sync:/sbin:/bin/sync
+shutdown:x:6:0:shutdown:/sbin:/sbin/shutdown
+halt:x:7:0:halt:/sbin:/sbin/halt
+mail:x:8:12:mail:/var/spool/mail:/sbin/nologin
+operator:x:11:0:operator:/root:/sbin/nologin
+games:x:12:100:games:/usr/games:/sbin/nologin
+ftp:x:14:50:FTP User:/var/ftp:/sbin/nologin
+cnb:x:1234:2345::/home/cnb:/bin/bash
+nobody:x:65534:65534:Kernel Overflow User:/:/sbin/nologin
+`), 0600)).To(Succeed())
+
+			duringBuilderPermissions := utils.GetDuringBuildPermissions(path)
+
+			Expect(duringBuilderPermissions).To(Equal(
+				structs.DuringBuildPermissions{
+					CNB_USER_ID:  1234,
+					CNB_GROUP_ID: 2345,
+				},
+			))
+		})
+	})
+
+	context("/etc/passwd exists and does NOT have the cnb user", func() {
+
+		it("It should return the default permissions", func() {
+			tmpDir, err = os.MkdirTemp("", "")
+			Expect(err).NotTo(HaveOccurred())
+
+			path = filepath.Join(tmpDir, "/passwd")
+
+			Expect(os.WriteFile(path, []byte(`root:x:0:0:root:/root:/bin/bash
+bin:x:1:1:bin:/bin:/sbin/nologin
+daemon:x:2:2:daemon:/sbin:/sbin/nologin
+adm:x:3:4:adm:/var/adm:/sbin/nologin
+lp:x:4:7:lp:/var/spool/lpd:/sbin/nologin
+sync:x:5:0:sync:/sbin:/bin/sync
+shutdown:x:6:0:shutdown:/sbin:/sbin/shutdown
+halt:x:7:0:halt:/sbin:/sbin/halt
+mail:x:8:12:mail:/var/spool/mail:/sbin/nologin
+operator:x:11:0:operator:/root:/sbin/nologin
+games:x:12:100:games:/usr/games:/sbin/nologin
+ftp:x:14:50:FTP User:/var/ftp:/sbin/nologin
+nobody:x:65534:65534:Kernel Overflow User:/:/sbin/nologin
+`), 0600)).To(Succeed())
+
+			duringBuildPermissions := utils.GetDuringBuildPermissions(path)
+
+			Expect(duringBuildPermissions).To(Equal(
+				structs.DuringBuildPermissions{
+					CNB_USER_ID:  ubinodejsextension.DEFAULT_USER_ID,
+					CNB_GROUP_ID: ubinodejsextension.DEFAULT_GROUP_ID},
+			))
+		})
+	})
+
+	context("/etc/passwd does NOT exist", func() {
+
+		it("It should return the default permissions", func() {
+			tmpDir, err = os.MkdirTemp("", "")
+			Expect(err).NotTo(HaveOccurred())
+
+			duringBuilderPermissions := utils.GetDuringBuildPermissions(tmpDir)
+
+			Expect(duringBuilderPermissions).To(Equal(
+				structs.DuringBuildPermissions{
+					CNB_USER_ID:  ubinodejsextension.DEFAULT_USER_ID,
+					CNB_GROUP_ID: ubinodejsextension.DEFAULT_GROUP_ID},
+			))
+		})
+	})
+}


Moved to utils_test from generate_test untouched.

pacostas · 2024-09-11T09:35:54Z

internal/utils/utils_test.go

+func testGenerateBuildDockerfile(t *testing.T, context spec.G, it spec.S) {
+
+	var (
+		Expect = NewWithT(t).Expect
+	)
+
+	context("Adding props on build.dockerfile template", func() {
+
+		it("Should fill with properties the template/build.Dockerfile", func() {
+
+			output, err := utils.GenerateBuildDockerfile(structs.BuildDockerfileProps{
+				NODEJS_VERSION: 16,
+				CNB_USER_ID:    1000,
+				CNB_GROUP_ID:   1000,
+				CNB_STACK_ID:   "io.buildpacks.stacks.ubi8",
+				PACKAGES:       ubinodejsextension.PACKAGES,
+			})
+
+			Expect(err).NotTo(HaveOccurred())
+			Expect(output).To(Equal(fmt.Sprintf(`ARG base_image
+FROM ${base_image}
+
+USER root
+
+ARG build_id=0
+RUN echo ${build_id}
+
+RUN microdnf -y module enable nodejs:16
+RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y %s && microdnf clean all
+
+RUN echo uid:gid "1000:1000"
+USER 1000:1000
+
+RUN echo "CNB_STACK_ID: io.buildpacks.stacks.ubi8"`, ubinodejsextension.PACKAGES)))
+
+		})
+
+	})
+}
+
+func testGenerateRunDockerfile(t *testing.T, context spec.G, it spec.S) {
+
+	var (
+		Expect = NewWithT(t).Expect
+	)
+
+	context("Adding props on build.dockerfile template", func() {
+
+		it("Should fill with properties the template/run.Dockerfile", func() {
+
+			RunDockerfileProps := structs.RunDockerfileProps{
+				Source: "paketocommunity/run-nodejs-18-ubi-base",
+			}
+
+			output, err := utils.GenerateRunDockerfile(RunDockerfileProps)
+
+			Expect(err).NotTo(HaveOccurred())
+			Expect(output).To(Equal(`FROM paketocommunity/run-nodejs-18-ubi-base`))
+
+		})
+	})
+}
+


This code is the same with the old testfillPropstotemplate

ubi-nodejs-extension/generate_test.go

Lines 41 to 91 in ac00b6c

func testFillPropsToTemplate(t *testing.T, context spec.G, it spec.S) {

var (

Expect = NewWithT(t).Expect

)

context("Adding props on templates with FillPropsToTemplate", func() {

it("Should fill with properties the template/build.Dockerfile", func() {

output, err := ubinodejsextension.FillPropsToTemplate(BuildDockerfileProps{

NODEJS_VERSION: 16,

CNB_USER_ID: 1000,

CNB_GROUP_ID: 1000,

CNB_STACK_ID: "",

PACKAGES: ubinodejsextension.PACKAGES,

}, buildDockerfileTemplate)

Expect(err).NotTo(HaveOccurred())

Expect(output).To(Equal(fmt.Sprintf(`ARG base_image

FROM ${base_image}

USER root

ARG build_id=0

RUN echo ${build_id}

RUN microdnf -y module enable nodejs:16

RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y %s && microdnf clean all

RUN echo uid:gid "1000:1000"

USER 1000:1000

RUN echo "CNB_STACK_ID: "`, ubinodejsextension.PACKAGES)))

})

it("Should fill with properties the template/run.Dockerfile", func() {

RunDockerfileProps := RunDockerfileProps{

Source: "paketocommunity/run-nodejs-18-ubi-base",

}

output, err := ubinodejsextension.FillPropsToTemplate(RunDockerfileProps, runDockerfileTemplate)

Expect(err).NotTo(HaveOccurred())

Expect(output).To(Equal(`FROM paketocommunity/run-nodejs-18-ubi-base`))

})

})

}

but it has been splitted into two sections to wrap this function one for the run dockerfile and one for the build dockerfile

pacostas · 2024-09-11T09:40:37Z

generate_test.go

-			workingDir = t.TempDir()
-			Expect(err).NotTo(HaveOccurred())
-


The error check here was wrong, the t.TempDir() does not return any err object, therefore has been deleted. The WorkingDir variable has been moved a little bit down, next to the buildplan creation.

pacostas · 2024-09-12T10:39:57Z

internal/utils/utils.go

+func GenerateConfigTomlContentFromImagesJson(imagesJsonPath string, stackId string) ([]byte, error) {
+	imagesJsonData, err := ParseImagesJsonFile(imagesJsonPath)
+	if err != nil {
+		return []byte{}, err
+	}
+
+	nodejsStacks, err := GetNodejsStackImages(imagesJsonData)
+	if err != nil {
+		return []byte{}, err
+	}
+
+	defaultNodeVersion, err := GetDefaultNodeVersion(nodejsStacks)
+	if err != nil {
+		return []byte{}, err
+	}
+
+	configTomlContent, err := CreateConfigTomlFileContent(defaultNodeVersion, nodejsStacks, stackId)
+	if err != nil {
+		return []byte{}, err
+	}
+
+	configTomlContentString := configTomlContent.Bytes()
+	return configTomlContentString, nil
+}


Added a wrapper, and for that wrapper on the utils tests we only test that it manages to return the result and that it manages to propagate an error. The type of the error, the type of the result and the edge cases are covered from the tests of the functions that are wrapped.

pacostas · 2024-09-12T10:45:18Z

integration/fetch_run_image_from_env.go

 				WithPullPolicy("always").
 				Execute(name, source)

-			Expect(err).NotTo(HaveOccurred(), logs.String())
+			Expect(err).To(HaveOccurred())


The function errors after the extension has run due to it tries to download the fake image nodeRunImage := "this-is-a-run-image". Therefore the build fails, so I changed it to only check the logs and that the build failed instead of checking the logs and checking and that the build that succeeded. If we can find an image that will always be available, we can have also the build to succeed. In any case the extension is tested properly so to me seems like there is no issue of test coverage on this scenario.

pacostas · 2024-09-12T11:57:24Z

@mhdawson The tests do not pass due to there is no new ubi-base image with the images.json file in it. If you force the release on the ubi-base-stack, it will generate one, which will update the builder and the tests of this PR will pass.

mhdawson · 2024-09-12T20:23:09Z

internal/utils/utils.go

+)
+
+var DEFAULT_USER_ID = 1002
+var DEFAULT_GROUP_ID = 1000


I wonder if these could be in a common place as we define them in multiple files?

mhdawson · 2024-09-12T20:26:37Z

Just one tiny question, otherwise looks good.

Pushed through a release of the stack, will re-run the tests.

pacostas · 2024-09-13T09:54:04Z

Yes, you are right. On the generate.go these constants are not being used anymore as the getDuringBuildPermissions function has been moved to utils package. Although I moved these constants to a new package called constants as are a bit hidden under the utils package. I can easily revert these changes by moving these constants under the utils package if you think is not on the context of this PR.
Also I added this commit 15c9400 which removes the tmp directory by using the builtin function for making tmp directories which also removes them automatically.

mhdawson

LGTM

pacostas force-pushed the images-json branch from 6dbb94a to cecf236 Compare August 16, 2024 15:42

pacostas force-pushed the images-json branch 2 times, most recently from bdccd09 to 8210c1f Compare September 10, 2024 11:28

pacostas commented Sep 10, 2024

View reviewed changes

generate_test.go Outdated Show resolved Hide resolved

pacostas added 14 commits September 11, 2024 12:16

POC of fetching the node versions from images.json

5c4c5a4

finalizing the implementation

082b4c6

adding error checking on imagesJson decoding

af7a1b8

using imagesManager to fetch imagejson file path

fdde2c3

refactor: adding more stuff inside createTomlFileFunction

fe4b218

proper name for the extension unit tests

78ac7c9

creating utils with tests and testdata

53e055f

removing imagesManager and adding a path instead

02938ef

saving config.toml file

9071d79

refactor: generate tests

a8bceb7

using structs

406cafa

refactor: moving rest of the utils under utils package

4b1645c

fixing integration tests to work with copied images.json

d98d467

fix: adding validation in case there are no nodejs stacks

1031862

pacostas force-pushed the images-json branch from 8210c1f to 1031862 Compare September 11, 2024 09:17

pacostas commented Sep 11, 2024

View reviewed changes

pacostas added 3 commits September 12, 2024 12:07

moving generateImagesJson testhelper function in a common place

64250c5

fix: fetch run image from env integration tests

276a7bc

reafactor:adding a wrapper on create config content functions

7a42902

pacostas commented Sep 12, 2024

View reviewed changes

pacostas marked this pull request as ready for review September 12, 2024 11:54

pacostas requested a review from a team as a code owner September 12, 2024 11:54

mhdawson added the semver:major A change requiring a major version bump label Sep 12, 2024

mhdawson reviewed Sep 12, 2024

View reviewed changes

fix: importing default values from extension

4ccc558

pacostas force-pushed the images-json branch from 12023c1 to 4ccc558 Compare September 13, 2024 08:27

fix: remove tmp directory

15c9400

pacostas force-pushed the images-json branch from 1b69ee2 to 15c9400 Compare September 13, 2024 09:51

mhdawson approved these changes Sep 13, 2024

View reviewed changes

mhdawson merged commit 37c1106 into paketo-community:main Sep 13, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Installing node from images.json #203

Installing node from images.json #203

pacostas commented Aug 16, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 11, 2024

pacostas Sep 12, 2024

pacostas Sep 12, 2024

pacostas commented Sep 12, 2024

mhdawson Sep 12, 2024

mhdawson commented Sep 12, 2024

pacostas commented Sep 13, 2024 •

edited

Loading

mhdawson left a comment

	it("Node no longer requested in buildplan", func() {

	generateResult, err = generate(packit.GenerateContext{
	WorkingDir: workingDir,
	Plan: packit.BuildpackPlan{
	Entries: []packit.BuildpackPlanEntry{},
	},
	})
	Expect(err).To(HaveOccurred())
	Expect(generateResult.BuildDockerfile).To(BeNil())
	})
	}, spec.Sequential())

	func testFillPropsToTemplate(t *testing.T, context spec.G, it spec.S) {

	var (
	Expect = NewWithT(t).Expect
	)

	context("Adding props on templates with FillPropsToTemplate", func() {

	it("Should fill with properties the template/build.Dockerfile", func() {

	output, err := ubinodejsextension.FillPropsToTemplate(BuildDockerfileProps{
	NODEJS_VERSION: 16,
	CNB_USER_ID: 1000,
	CNB_GROUP_ID: 1000,
	CNB_STACK_ID: "",
	PACKAGES: ubinodejsextension.PACKAGES,
	}, buildDockerfileTemplate)

	Expect(err).NotTo(HaveOccurred())
	Expect(output).To(Equal(fmt.Sprintf(`ARG base_image
	FROM ${base_image}

	USER root

	ARG build_id=0
	RUN echo ${build_id}

	RUN microdnf -y module enable nodejs:16
	RUN microdnf --setopt=install_weak_deps=0 --setopt=tsflags=nodocs install -y %s && microdnf clean all

	RUN echo uid:gid "1000:1000"
	USER 1000:1000

	RUN echo "CNB_STACK_ID: "`, ubinodejsextension.PACKAGES)))

	})

	it("Should fill with properties the template/run.Dockerfile", func() {

	RunDockerfileProps := RunDockerfileProps{
	Source: "paketocommunity/run-nodejs-18-ubi-base",
	}

	output, err := ubinodejsextension.FillPropsToTemplate(RunDockerfileProps, runDockerfileTemplate)

	Expect(err).NotTo(HaveOccurred())
	Expect(output).To(Equal(`FROM paketocommunity/run-nodejs-18-ubi-base`))

	})
	})
	}

Installing node from images.json #203

Installing node from images.json #203

Conversation

pacostas commented Aug 16, 2024

Summary

Use Cases

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pacostas commented Sep 12, 2024

Choose a reason for hiding this comment

mhdawson commented Sep 12, 2024

pacostas commented Sep 13, 2024 • edited Loading

mhdawson left a comment

Choose a reason for hiding this comment

pacostas commented Sep 13, 2024 •

edited

Loading