Fix TCPServer being bound before allow_reuse_address is set (#711)

palantir · Dec 24, 2019 · 914d4e1 · 914d4e1
1 parent b862add
commit 914d4e1
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/pyls/python_ls.py b/pyls/python_ls.py
@@ -68,10 +68,12 @@ def shutdown_server(*args):
          'SHUTDOWN_CALL': shutdown_server}
     )
 
-    server = socketserver.TCPServer((bind_addr, port), wrapper_class)
+    server = socketserver.TCPServer((bind_addr, port), wrapper_class, bind_and_activate=False)
     server.allow_reuse_address = True
 
     try:
+        server.server_bind()
+        server.server_activate()
         log.info('Serving %s on (%s, %s)', handler_class.__name__, bind_addr, port)
         server.serve_forever()
     finally: