Use Byte Buddy for Instrumentation by default #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behavior can be used by setting the `instrument.dynamic-proxy` property to `true`.
carterkozak
requested review from
schlosna,
dansanduleac,
CRogers,
iamdanfox and
ferozco
Generate changelog in
|
|
Is it worth getting Java12/13 tests running on our OSS repos too? |
|
I fully support testing everything we possibly can. I've manually verified that the relevant tests to this change pass on java 12. |
schlosna
reviewed
Sep 6, 2019
schlosna
approved these changes
Sep 9, 2019
|
Going to defer to @carterkozak when he's comfortable marking to "merge when ready" given ApacheCon this week |
|
I have comms, let's ship it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous behavior can be used by setting the
instrument.dynamic-proxyproperty totrue.Before this PR
Dynamic proxies were used by default.
After this PR
==COMMIT_MSG==
Use Byte Buddy for Instrumentation by default, reducing excess stack frames from instrumentation.
==COMMIT_MSG==
Possible downsides?
There's always a risk in change, particularly for environments with complex class loader hierarchies and security managers. We've rolled this out to our largest project already without any issues.