Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add callable key support for RedisCache #348

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Add callable key support for RedisCache #348

merged 3 commits into from
Feb 11, 2024

Conversation

northernSage
Copy link
Member

@northernSage northernSage commented Feb 10, 2024 •
edited
Loading

following #332

  • fix broken type hints for callable keys
  • add tests
  • add changelog
  • update docs

@northernSage northernSage self-assigned this Feb 10, 2024
@northernSage northernSage marked this pull request as draft February 10, 2024 16:21
@northernSage northernSage force-pushed the redis-key-callable-support branch 3 times, most recently from 6384d8a to 5edc237 Compare February 10, 2024 16:43
@northernSage northernSage changed the title Redis key callable support Add callable key support for RedisCache Feb 10, 2024
@northernSage northernSage mentioned this pull request Feb 10, 2024
Closed
@dbascoules
Copy link

dbascoules commented Feb 11, 2024 •
edited
Loading

@northernSage northernSage force-pushed the redis-key-callable-support branch from 5edc237 to fdfa9cb Compare February 11, 2024 13:43
@northernSage northernSage linked an issue Feb 11, 2024 that may be closed by this pull request
Redis doesn't supports function as a key_prefix anymore #331
Closed
@northernSage northernSage marked this pull request as ready for review February 11, 2024 13:47
@northernSage northernSage added the enhancement New feature or request label Feb 11, 2024
@northernSage northernSage force-pushed the redis-key-callable-support branch from fdfa9cb to c2311f9 Compare February 11, 2024 13:48
@northernSage northernSage merged commit bf1f8fd into pallets-eco:main Feb 11, 2024
7 of 8 checks passed
@northernSage northernSage deleted the redis-key-callable-support branch February 11, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@northernSage northernSage

Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redis doesn't supports function as a key_prefix anymore
2 participants
@northernSage @dbascoules