Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat : upgraded the app with gravity module to SDK v0.50.0 #1041

Merged
merged 7 commits into from
Dec 19, 2023
Merged

feat : upgraded the app with gravity module to SDK v0.50.0 #1041

merged 7 commits into from
Dec 19, 2023

Conversation

ruthishvitwit
Copy link

No description provided.

@ruthishvitwit ruthishvitwit changed the base branch from master to v0.50.0-upgrade November 23, 2023 11:37
byte-bandit
byte-bandit requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at my comments from #1044 and make sure to apply them here.

aleem1314
aleem1314 suggested changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there are few things need to be updated.
Check #1036 (review)

@aleem1314
Copy link
Contributor

@ruthishvitwit resolve conflicts

@deepan95dev deepan95dev marked this pull request as ready for review December 11, 2023 11:10
aleem1314
aleem1314 reviewed Dec 11, 2023
View reviewed changes
util/liblog/liblog.go Outdated Show resolved Hide resolved
aleem1314
aleem1314 reviewed Dec 11, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@ruthishvitwit ruthishvitwit changed the title feat : upgraded the app with gravity module to SDK v0.5 feat : upgraded the app with gravity module to SDK v0.50.0 Dec 12, 2023
aleem1314
aleem1314 reviewed Dec 12, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
aleem1314
aleem1314 reviewed Dec 13, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
aleem1314
aleem1314 reviewed Dec 13, 2023
View reviewed changes
app/app.go Outdated Show resolved Hide resolved
@deepan95dev deepan95dev removed the request for review from alexanderbez December 14, 2023 11:46
aleem1314
aleem1314 previously approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

aleem1314
aleem1314 previously approved these changes Dec 15, 2023
View reviewed changes
byte-bandit
byte-bandit previously approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of stuff that needs improving, but was already lacking before and isn't part of this scope. Only one small remark, mostly looks good.

x/gravity/keeper/attestation_handler.go Outdated Show resolved Hide resolved
@ruthishvitwit ruthishvitwit dismissed stale reviews from byte-bandit and aleem1314 via 8ac2df6 December 18, 2023 04:54
byte-bandit
byte-bandit previously approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, final review to @aleem1314

aleem1314
aleem1314 previously approved these changes Dec 18, 2023
View reviewed changes
@aleem1314 aleem1314 enabled auto-merge (squash) December 18, 2023 11:18
@ruthishvitwit ruthishvitwit dismissed stale reviews from aleem1314 and byte-bandit via 5632d72 December 18, 2023 11:22
@taariq taariq self-requested a review December 19, 2023 04:33
taariq
taariq approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after @byte-bandit and @aleem1314

@aleem1314 aleem1314 merged commit 2a353b0 into v0.50.0-upgrade Dec 19, 2023
0 of 2 checks passed
@aleem1314 aleem1314 deleted the gravity-changes branch December 19, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepan95dev deepan95dev deepan95dev left review comments

@aleem1314 aleem1314 aleem1314 approved these changes

@taariq taariq taariq approved these changes

@byte-bandit byte-bandit byte-bandit left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ruthishvitwit @aleem1314 @taariq @byte-bandit @deepan95dev