Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:upgraded the app with treasury module to SDK v0.50 #1042

Merged
merged 4 commits into from
Dec 16, 2023

Conversation

vishal-kanna
Copy link
Contributor

No description provided.

@vishal-kanna vishal-kanna changed the base branch from master to v0.50.0-upgrade November 24, 2023 05:55
@aleem1314
Copy link
Contributor

Check #1036 PR review comments. Apply relevant changes here too.

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still there are few things need to be updated.
Check #1036 (review)

@aleem1314
Copy link
Contributor

@vishal-kanna resolve conflicts.

byte-bandit
byte-bandit previously approved these changes Dec 12, 2023
Copy link
Contributor

@byte-bandit byte-bandit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, final review goes to @aleem1314

x/treasury/genesis.go Outdated Show resolved Hide resolved
x/treasury/genesis.go Outdated Show resolved Hide resolved
aleem1314
aleem1314 previously approved these changes Dec 15, 2023
Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@aleem1314 aleem1314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@taariq taariq self-requested a review December 16, 2023 17:01
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@taariq taariq merged commit e74a669 into v0.50.0-upgrade Dec 16, 2023
0 of 2 checks passed
@taariq taariq deleted the treasury-changes branch December 16, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants