Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add more pigeon status update fields #1051

Merged
merged 4 commits into from
Dec 5, 2023
Merged

feat: Add more pigeon status update fields #1051

merged 4 commits into from
Dec 5, 2023

Conversation

byte-bandit
Copy link
Contributor

@byte-bandit byte-bandit commented Dec 5, 2023 •
edited
Loading

Related Github tickets

Background

This adds additional arbitrary logging fields to Pigeon status updates.

Testing completed

  • test coverage exists or has been added/updated
  • tested in a private testnet

Breaking changes

  • I have checked my code for breaking changes
  • If there are breaking changes, there is a supporting migration.

@byte-bandit byte-bandit marked this pull request as draft December 5, 2023 11:17
taariq
taariq approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@taariq taariq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Telemetry. LGTM

@byte-bandit byte-bandit marked this pull request as ready for review December 5, 2023 16:03
@byte-bandit byte-bandit merged commit fa06d2f into palomachain:master Dec 5, 2023
2 checks passed
@byte-bandit byte-bandit deleted the feature/pigeon-status-update branch December 5, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taariq taariq taariq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byte-bandit @taariq