Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH1039 Clear tests and add typehint for Series.unique with datetime/timedelta #1040

Merged
merged 2 commits into from
Nov 21, 2024
Merged

GH1039 Clear tests and add typehint for Series.unique with datetime/timedelta #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
09bb873
GH1039 Clear tests and add typehint for Series.unique with datetime/t…
loicdiridollou Nov 20, 2024
d7dbf67
Formatting
loicdiridollou Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pandas-stubs/core/series.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ from pandas.core.api import (
Int32Dtype as Int32Dtype,
Int64Dtype as Int64Dtype,
)
from pandas.core.arrays import TimedeltaArray
from pandas.core.arrays.base import ExtensionArray
from pandas.core.arrays.categorical import CategoricalAccessor
from pandas.core.arrays.datetimes import DatetimeArray
from pandas.core.arrays.interval import IntervalArray
from pandas.core.base import IndexOpsMixin
from pandas.core.frame import DataFrame
Expand Down Expand Up @@ -2113,6 +2115,7 @@ class TimestampSeries(Series[Timestamp]):
) -> TimestampSeries: ...
def __mul__(self, other: float | Series[int] | Series[float] | Sequence[float]) -> TimestampSeries: ... # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
def __truediv__(self, other: float | Series[int] | Series[float] | Sequence[float]) -> TimestampSeries: ... # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
def unique(self) -> DatetimeArray: ... # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
def mean( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
self,
axis: AxisIndex | None = ...,
Expand Down Expand Up @@ -2156,6 +2159,7 @@ class TimedeltaSeries(Series[Timedelta]):
def __mul__( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
self, other: num | Sequence[num] | Series[int] | Series[float]
) -> TimedeltaSeries: ...
def unique(self) -> TimedeltaArray: ... # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
def __sub__( # type: ignore[override] # pyright: ignore[reportIncompatibleMethodOverride]
self,
other: (
Expand Down
16 changes: 15 additions & 1 deletion tests/test_series.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@
ExtensionArray,
ExtensionDtype,
)
from pandas.core.arrays.datetimes import DatetimeArray
from pandas.core.arrays.timedeltas import TimedeltaArray
from pandas.core.window import ExponentialMovingWindow
import pytest
from typing_extensions import (
Expand Down Expand Up @@ -577,7 +579,7 @@ def test_types_value_counts() -> None:

def test_types_unique() -> None:
s = pd.Series([-10, 2, 2, 3, 10, 10])
s.unique()
check(assert_type(s.unique(), np.ndarray), np.ndarray)


def test_types_apply() -> None:
Expand Down Expand Up @@ -3373,3 +3375,15 @@ def test_case_when() -> None:
]
)
check(assert_type(r, pd.Series), pd.Series)


def test_series_unique_timestamp() -> None:
"""Test type return of Series.unique on Series[datetime64[ns]]."""
sr = pd.Series(pd.bdate_range("2023-10-10", "2023-10-15"))
check(assert_type(sr.unique(), DatetimeArray), DatetimeArray)


def test_series_unique_timedelta() -> None:
"""Test type return of Series.unique on Series[timedeta64[ns]]."""
sr = pd.Series([pd.Timedelta("1 days"), pd.Timedelta("3 days")])
check(assert_type(sr.unique(), TimedeltaArray), TimedeltaArray)
Loading