Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: use compiled nightly mypy #787

Merged
merged 3 commits into from
Oct 2, 2023
Merged

CI: use compiled nightly mypy #787

merged 3 commits into from
Oct 2, 2023

Conversation

twoertwein
Copy link
Member

Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @twoertwein

@Dr-Irv Dr-Irv merged commit 7e72ed8 into pandas-dev:main Oct 2, 2023
10 checks passed
@twoertwein
Copy link
Member Author

Not bad, from 3min46 to 1min17 :)

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Oct 2, 2023

Not bad, from 3min46 to 1min17 :)

Yes. Unfortunately, the mypy nightly job is failing because we need to add a # type: ignore[misc] in Series.__new__(), but if we do that, then the regular CI with mypy 1.5.1 will fail.

@twoertwein
Copy link
Member Author

I'm unsure whether we can fix that issue by re-writing the overloads. In the worst case, we could ignore overload-specific ignores on the nightly run (we already ignore unused ignore comments).

@twoertwein twoertwein deleted the mypyc branch February 10, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants