-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify optional workflows to be triggered by comments #977
Conversation
Right now there is a bit of code duplication in the yaml file but open to clean up, I will add a readme file to guide the operations. |
I'm going to let @twoertwein review, approve and merge this, but one thing that I see is that you removed the |
I misunderstood then, I thought the idea was to replace as those optionals were put in place as a workaround. I will restore them so that they get triggered at every merge, sorry for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @loicdiridollou
assert_type()
to assert the type of any return valueThis PR tries to modify how we run nightly/strict workflows to avoid having to run them systematically on merge to main but instead by able to do so by commenting on the PR with comments like
/pandas_nightly
,mypy_nightly
or/pyright_strict
.The process would go as such:
/pandas_nightly
as below