Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify optional workflows to be triggered by comments #977

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

loicdiridollou
Copy link
Contributor

This PR tries to modify how we run nightly/strict workflows to avoid having to run them systematically on merge to main but instead by able to do so by commenting on the PR with comments like /pandas_nightly, mypy_nightly or /pyright_strict.

The process would go as such:

  • You write some code and open a PR in the repo
  • You comment in the PR one of the commands like /pandas_nightly as below
image - From there, the action kicks in and run the tests. - Once done, the results are published in a check run like below with a link to the action so that it is convenient to access the detailed results. image

@loicdiridollou
Copy link
Contributor Author

Right now there is a bit of code duplication in the yaml file but open to clean up, I will add a readme file to guide the operations.

@Dr-Irv Dr-Irv requested a review from twoertwein August 12, 2024 17:14
@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Aug 12, 2024

I'm going to let @twoertwein review, approve and merge this, but one thing that I see is that you removed the optional runs that occur during a merge. I think those should remain, because otherwise, as someone doing many of the merges and getting those reports, I won't see what's failing on a regular basis and know what needs to be fixed.

@loicdiridollou
Copy link
Contributor Author

I'm going to let @twoertwein review, approve and merge this, but one thing that I see is that you removed the optional runs that occur during a merge. I think those should remain, because otherwise, as someone doing many of the merges and getting those reports, I won't see what's failing on a regular basis and know what needs to be fixed.

I misunderstood then, I thought the idea was to replace as those optionals were put in place as a workaround. I will restore them so that they get triggered at every merge, sorry for that.

.github/workflows/comment_commands.yml Outdated Show resolved Hide resolved
.github/workflows/comment_commands.yml Outdated Show resolved Hide resolved
.github/workflows/comment_commands.yml Outdated Show resolved Hide resolved
docs/tests.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@Dr-Irv Dr-Irv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr-Irv Dr-Irv merged commit b246fcf into pandas-dev:main Sep 4, 2024
10 checks passed
@loicdiridollou loicdiridollou deleted the gh613_comment_ci branch September 13, 2024 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a way to test nightly locally, or as part of a PR that fixes nightly
3 participants