-
-
Notifications
You must be signed in to change notification settings - Fork 18k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RLS: 1.4.2 #45961
Comments
I'm not sure that the quantity of fixes in 1.4.2 currently warrant a release yet. |
sure let's wait a bit |
There is a few more fixes since I last commented here. Any objections to releasing this weekend? |
ok for release @simonjayhawkins |
i've closed off 1.4.2 to new additions and opened https://github.com/pandas-dev/pandas/milestone/95 for 1.4.3, currently schedule for 4 weeks from tomorrow, April 30, 2022 |
it looks like nightlies are failing for all wheels on main and also for 1.4.x on macOS for test_pickle_frame_v124_unpickle_130 (which also fails on main so it is not down to a PR on main not backported to 1.4.x) wheels don't build if tests fail, so may need to skip that test, or will hold off release if someone gets a chance to investigate (I have a few more things to do tonight to prep so probably won't get chance to investigate that today) cc @lithomas1 |
and more importantly not a mac user so unlikely to get far investigating anyway. |
The problematic filename is have we changed the sdist build recently? |
what has changed in pandas-wheels is that setuptools has been pinned @lithomas1 this was done to get the nightlies to green so I guess not likely the issue? |
this is not related to the 1.4.x release but it looks like the last successful nightly build was 23rd March and the changes to test_bytes_exceed_2gb which are not failing on 1.4.x were before that in #46261. cc @mroeschke |
forget that, the green builds on 23rd were not from main, Last green build from main was Feb 17, with no logs till March 3, so could be related to #46261 |
OK looks good to start release tomorrow morning (UK time) |
release checklist for commit 8fab03d
|
starting release now
|
You probably already do this, but I learned this week that sdist should be uploaded after wheels in order to Pypi warehouse to get Metadata that is then available for package managers like poetry. |
the scripts use twine. And IIRC the sdist is always done last. |
We have had 2 "release related" issues reported, #46615 and #46618 I'm assuming #46615 can be fixed without another release. @jorisvandenbossche ? It looks like the issue in #46618 occurs pre 1.4.2. xref #46618 (comment) Will announce release shortly if no objections. |
no objection |
Yes, although it might be nice if we could fix it earlier. But even then it should be possible to do that without cutting a new release (but using a different environment when building the docs) |
@simonjayhawkins for the actual release docs, you are uploading locally built docs? (using pandas-dev/pandas-release#33) In that case, would it be possible to rebuild and reupload them using a small change in the environment that you are building with? (pinning pydata-sphinx-theme, see #46663) |
sure. |
right the switcher should work now, but the date does not match the release date. |
Tracking issue for the 1.4.2 release.
https://github.com/pandas-dev/pandas/milestone/94
Currently scheduled for March 05, 2022.
This is 3 weeks from today assuming a release schedule of 3-3-4-5-6 weeks for 1.4.1 through 1.4.5.
List of open regressions: https://github.com/pandas-dev/pandas/issues?q=is%3Aopen+is%3Aissue+label%3ARegression
cc @pandas-dev/pandas-core @pandas-dev/pandas-triage
The text was updated successfully, but these errors were encountered: