Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github action for release #36704

Closed
wants to merge 4 commits into from

Conversation

simonjayhawkins
Copy link
Member

@simonjayhawkins simonjayhawkins commented Sep 28, 2020

for initial feedback. maybe way off base with this.

can be seen in action at https://github.com/simonjayhawkins/pandas/actions

the alternative of retaining a separate repo for release can be seen at https://github.com/simonjayhawkins/pandas-release/actions

@@ -0,0 +1,63 @@
#!/usr/bin/env python3
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this script from pandas-release.

if we want to trigger actions probably better to have in same repo.

@@ -0,0 +1,51 @@
{% set version = environ.get("PANDAS_VERSION") %}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from pandas-release and deleted the current recipe in pandas (may still want to retain existing though as builds from source instead of sdist)

version: {{ version }}

source:
url: ../dist/pandas-{{ version }}.tar.gz
Copy link
Member Author

@simonjayhawkins simonjayhawkins Sep 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line changed otherwise copy and paste

"RLS: {}".format(tag[1:]),
]
)
subprocess.check_call(["git", "tag", "-a", tag, "-m", "Version {}".format(tag[1:])])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moreless copy and paste. deleted sync with upstream as working with origin

Comment on lines +10 to +13
# push-tag:
# description: 'Push tag on success?'
# default: 'false'
# required: true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wip

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once we have a tag we have a trigger for release

@simonjayhawkins
Copy link
Member Author

closing. wanted to avoid sharing credentials between repos just for tagging but going to continue using pandas-release for a bit.

@simonjayhawkins
Copy link
Member Author

I've re-opened so we have somewhere to discuss implementation details.

This is based off a workflow that I am using to test release readiness for the backport branch that I run manually.

I think, since the backport branch doesn't have too many commits, could change this from a manual trigger to run on push to 1.1.x

@simonjayhawkins simonjayhawkins added CI Continuous Integration Needs Discussion Requires discussion from core team before further action Release labels Oct 19, 2020
@jreback
Copy link
Contributor

jreback commented Jan 1, 2021

@simonjayhawkins move to pandas-release repo?

@simonjayhawkins
Copy link
Member Author

@simonjayhawkins move to pandas-release repo?

probably need more discussion in #21050 before we can make progress here. closing to clear queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration Needs Discussion Requires discussion from core team before further action Release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants