Fix BUG: Cannot shift Intervals that are not closed='right' (the default) #60407
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
approved these changes
Nov 25, 2024
|
Thanks @lfffkh |
snitish
pushed a commit
to snitish/pandas
that referenced
this pull request
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shiftIntervals that are notclosed='right'(the default) #60389I made a small modification by adding the closed attribute when creating empty positions for movement. Now we can output the moved result correctly according to the requirements in the issue
At the same time, I added a little test for this modification.
If my understanding of the problem is beyond the problem, or if my modifications are incorrect, please feel free to point them out