-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chunking_introduction.ipynb #9
Conversation
single kerchunk file doesn't require .open_mfdataset but only .open_dateset
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Also added a new link to the GAUL repository |
View / edit / reply to this conversation on ReviewNB acocac commented on 2023-10-18T09:26:40Z Would it be possible to add a heading to this cell and the following one e.g. Load packages. We can also add some markdown describing the cells first check certain libraries such as openeo are available in the virtual environment. If not, this is installed via mamba. pl-marasco commented on 2023-10-18T10:00:25Z I would consider not that usefull but I will |
View / edit / reply to this conversation on ReviewNB acocac commented on 2023-10-18T09:26:41Z This should be a markdown cell and not raw. pl-marasco commented on 2023-10-18T10:01:18Z that's definetly a mistake indeed. |
View / edit / reply to this conversation on ReviewNB acocac commented on 2023-10-18T09:26:42Z I got the following error:
--------------------------------------------------------------------------- OpenEoApiError Traceback (most recent call last) Input In [10], in <cell line: 1>() ----> 1 datacube.download(f"C_GLS_NDVI_20220101_20220701_{AOI_name}_S3_2.nc", format="NetCDF")
pl-marasco commented on 2023-10-18T09:57:52Z Right, as I was pointg during the discussion with the OpenEO guys it's not anymore possible to use the VITO's backend for free and credit's are now in place. Up to now I don't know other backend and I've to test other solution. I would leave this as it is. Morover this is not a notebook that will be used in the workshop but the purpose was only to let Michele follow the overall processing flow. acocac commented on 2023-10-18T12:39:56Z Great - It makes then sense to leave as it's. fyi, the wildfire notebook won't be used too. However, I've implemented the changes suggested by Michele. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pl-marasco
Thanks for working on these notebooks.
The chunking notebook works fine.
The xarray handson notebook requires some work. Please check my comments through ReviewNB.
Right, as I was pointg during the discussion with the OpenEO guys it's not anymore possible to use the VITO's backend for free and credit's are now in place. Up to now I don't know other backend and I've to test other solution. I would leave this as it is. Morover this is not a notebook that will be used in the workshop but the purpose was only to let Michele follow the overall processing flow. View entire conversation on ReviewNB |
I would consider not that usefull but I will View entire conversation on ReviewNB |
that's definetly a mistake indeed. View entire conversation on ReviewNB |
Great - It makes then sense to leave as it's. fyi, the wildfire notebook won't be used too. However, I've implemented the changes suggested by Michele. View entire conversation on ReviewNB |
@acocac @pl-marasco can you please confirm that I can merge? |
All is ok. The suggested changes affect mainly one of the notebooks within the example folder. |
single kerchunk file doesn't require .open_mfdataset but only .open_dateset