Skip to content
This repository has been archived by the owner on Dec 7, 2023. It is now read-only.

Patch for #132, generalize synchronize error #154

Merged
merged 3 commits into from
Sep 30, 2022
Merged

Conversation

cisaacstern
Copy link
Member

@cisaacstern cisaacstern commented Sep 30, 2022

I started pangeo-forge/pangeo-forge-runner#34 to try to address #132, but quickly realized that this is not an easy (for me) at least issue to solve upstream. So I'm adding a patch for #132 in this PR. This PR also closes #97.

Note: this was motivated by #150 (comment), and I thought it was cleaner to handle this in its own PR, rather than fixing it there.

@cisaacstern cisaacstern temporarily deployed to pforge-pr-154 September 30, 2022 07:55 Inactive
@cisaacstern cisaacstern merged commit e626cfd into main Sep 30, 2022
@cisaacstern cisaacstern deleted the pfr-error-handling branch September 30, 2022 08:01
@cisaacstern cisaacstern restored the pfr-error-handling branch September 30, 2022 08:05
@andersy005 andersy005 deleted the pfr-error-handling branch October 10, 2022 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In synchronize, close check runs for all subprocess.CalledProcessErrors
1 participant