Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return target_store from StoreToZarr stage #562

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Conversation

jbusecke
Copy link
Contributor

Superseeds jbusecke#1 (see over there for discussion).

Superseeds jbusecke#1 (see over there for discussion).
@cisaacstern
Copy link
Member

This looks good, and the change is from returning nothing (store_dataset_fragment returns None)

def store_dataset_fragment(
item: Tuple[Index, xr.Dataset], target_store: zarr.storage.FSStore
) -> None:

to returning something, so I don't think we need to worry about a breaking change.

This is simple enough that I think we can leave it without an explicit test. Thanks @jbusecke, great enhancement!

@cisaacstern cisaacstern merged commit 0ee97ff into main Aug 10, 2023
11 checks passed
@cisaacstern cisaacstern deleted the return-target-store branch August 10, 2023 19:22
@jbusecke
Copy link
Contributor Author

Yayyyy! Ill move on with building testing an cataloging stages in the CMIP6 repo. Thanks for the quick merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants