Move almost everything to pyproject.toml #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yuvipanda
commented
Aug 19, 2023
•
yuvipanda
commented
- Mixing pyproject.toml and setup.cfg the way we were doing seems to cause weird problems with entrypoints
- I've moved things to their equivalent values, except when they are the default - in which case I've left it out
- I don't understand if the mypy things are still needed, so I've left them as they are.
- flake8 doesn't support reading from pyproject.toml yet, so letting it be.
- setup.cfg is old school INI, pyproject.toml is where everyone is moving to - Mixing pyproject.toml and setup.cfg the way we were doing seems to cause weird problems with entrypoints. - I've moved things to their equivalent values, except when they are the default - in which case I've left it out - I don't understand if the mypy things are still needed, so I've left them as they are. - flake8 doesn't support reading from pyproject.toml yet, so letting it be.
|
LGTM, thanks @yuvipanda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.